Rewrite SpanHelpers.IndexOfNullByte/IndexOfNullCharacter to unmanaged pointers #81347
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsAddresses #81332
|
|
|
||
| internal static unsafe int strlen(byte* ptr) => SpanHelpers.IndexOfNullByte(ref *ptr); | ||
| internal static unsafe int strlen(byte* ptr) => SpanHelpers.IndexOfNullByte(ptr); |
There was a problem hiding this comment.
a nit: we can use SpanHelpers.IndexOfNullByte directly at call-sites and delete these wrappers to promote the usage of same API everywhere (CoreLib has total 21 call-sites of wcslen and strlen combined).
There was a problem hiding this comment.
a nit: we can use
SpanHelpers.IndexOfNullBytedirectly at call-sites and delete these wrappers to promote the usage of same API everywhere (CoreLib has total 21 call-sites ofwcslenandstrlencombined).
It's a bit more complicated too delete it - e.g. VM relies on it for IL marshallers, mono seems too
There was a problem hiding this comment.
Ah corelib.h, forgot to check that. 😁
(they are used in ilmarshalers.cpp via METHOD__STRING__STRLEN and METHOD__STRING__WCSLEN macros)
Calls in C# code can use SpanHelpers directly.
There was a problem hiding this comment.
Calls in C# code can use SpanHelpers directly.
I wonder if in this case ILLink will trim strlen/the other one as unused and then VM will crash, so probably better to leave as is or rename completely?
There was a problem hiding this comment.
For CoreCLR, ILLink keeps everything referenced by VM. I am not sure about Mono.
Addresses #81332