Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 5/23/2022 7:50:08 PM #5480

Closed
performanceautofiler bot opened this issue May 24, 2022 · 1 comment
Closed

[Perf] Changes at 5/23/2022 7:50:08 PM #5480

performanceautofiler bot opened this issue May 24, 2022 · 1 comment
Assignees
Labels
arch-x64 branch-refs/heads/main kind-micro os-linux perf-improvement PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr untriaged

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented May 24, 2022

Run Information

Architecture x64
OS ubuntu 18.04
Baseline a0ff92c8d3cb3cb3b35357117e629cdd19f7080a
Compare cd6512d071d0a32c90fa81a64abd258d707cfa5f
Diff Diff

Improvements in Span.IndexerBench

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
KnownSizeCtor2 - Duration of single invocation 511.92 ns 392.38 ns 0.77 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'Span.IndexerBench*'

Payloads

Baseline
Compare

Histogram

Span.IndexerBench.KnownSizeCtor2(length: 1024)


Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 392.3849264384877 < 486.29085751591896.
IsChangePoint: Marked as a change because one of 5/23/2022 3:43:39 PM, 5/24/2022 7:58:36 AM falls between 5/15/2022 6:57:22 PM and 5/24/2022 7:58:36 AM.
IsImprovementStdDev: Marked as improvement because 856.2952791052381 (T) = (0 -392.5221603750245) / Math.Sqrt((0.1659385220532533 / (299)) + (0.037666306674774025 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.23298633544649552 = (511.753803765048 - 392.5221603750245) / 511.753803765048 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS ubuntu 18.04
Baseline a0ff92c8d3cb3cb3b35357117e629cdd19f7080a
Compare cd6512d071d0a32c90fa81a64abd258d707cfa5f
Diff Diff

Improvements in System.Memory.Span<Byte>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Fill - Duration of single invocation 5.37 ns 4.23 ns 0.79 0.35 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Memory.Span&lt;Byte&gt;*'

Payloads

Baseline
Compare

Histogram

System.Memory.Span<Byte>.Fill(Size: 512)


Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 4.225107000151447 < 4.640476446476955.
IsChangePoint: Marked as a change because one of 4/21/2022 3:06:05 PM, 4/22/2022 2:26:33 AM, 5/20/2022 9:09:19 PM, 5/23/2022 3:43:39 PM, 5/24/2022 7:58:36 AM falls between 5/15/2022 6:57:22 PM and 5/24/2022 7:58:36 AM.
IsImprovementStdDev: Marked as improvement because 8.804313967751114 (T) = (0 -4.176020078575413) / Math.Sqrt((1.4641128487692439 / (299)) + (0.004819051739623447 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.15269333125634577 = (4.928581625313319 - 4.176020078575413) / 4.928581625313319 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added CoreClr PGO Applied if there were any profile guided optimization updates in the observed interval. untriaged labels May 24, 2022
@kunalspathak
Copy link
Member

kunalspathak commented Jun 2, 2022

possibly by dotnet/runtime#69247 or PGO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x64 branch-refs/heads/main kind-micro os-linux perf-improvement PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr untriaged
Projects
None yet
Development

No branches or pull requests

1 participant