-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IntegralRange in fgOptimizeRelationalComparisonWithCasts #69247
Merged
jakobbotsch
merged 9 commits into
dotnet:main
from
jakobbotsch:better-rel-comparison-with-casts-opts
May 23, 2022
Merged
Use IntegralRange in fgOptimizeRelationalComparisonWithCasts #69247
jakobbotsch
merged 9 commits into
dotnet:main
from
jakobbotsch:better-rel-comparison-with-casts-opts
May 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 12, 2022
ghost
assigned jakobbotsch
May 12, 2022
Tagging subscribers to this area: @JulieLeeMSFT |
This comment was marked as outdated.
This comment was marked as outdated.
Diff for example in #69200: mov qword ptr [rsp+28H], rax
;; size=11 bbWeight=1 PerfScore 1.50
G_M28380_IG02:
- mov eax, edx
- mov r8d, dword ptr [rcx+8]
- cmp rax, r8
+ cmp edx, dword ptr [rcx+8]
ja SHORT G_M28380_IG04
mov rcx, bword ptr [rcx]
mov bword ptr [rsp+28H], rcx
@@ -43,7 +41,7 @@ G_M28380_IG02:
lea rcx, bword ptr [rsp+28H]
call [Program:DoIt(ReadOnlySpan`1)]
nop
- ;; size=35 bbWeight=1 PerfScore 11.25
+ ;; size=29 bbWeight=1 PerfScore 11.75
G_M28380_IG03:
add rsp, 56
ret
@@ -53,6 +51,6 @@ G_M28380_IG04:
int3
;; size=7 bbWeight=0 PerfScore 0.00
-; Total bytes of code 58, prolog size 11, PerfScore 19.80, instruction count 17, allocated bytes for code 58 (MethodHash=f8b59123) for method Program:M(ReadOnlySpan`1,int)
+; Total bytes of code 52, prolog size 11, PerfScore 19.70, instruction count 15, allocated bytes for code 52 (MethodHash=f8b59123) for method Program:M(ReadOnlySpan`1,int)
; ============================================================ |
/azp run Fuzzlyn |
Azure Pipelines successfully started running 1 pipeline(s). |
cc @dotnet/jit-contrib @GrabYourPitchforks |
jakobbotsch
commented
May 16, 2022
SingleAccretion
approved these changes
May 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great (modulo nits)!
EgorBo
approved these changes
May 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69200
Diffs