Skip to content

Commit

Permalink
[wasm] Fix failures due to illinker not preserving enough (#2574)
Browse files Browse the repository at this point in the history
* [wasm] Preserve members with ILLinker, issue: #2563

* cleanup
  • Loading branch information
radical authored Aug 25, 2022
1 parent 2fd6ac8 commit 7586fb5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/ci_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def add_arguments(parser: ArgumentParser) -> ArgumentParser:

def __is_valid_dotnet_path(dp: str) -> str:
if not os.path.isdir(dp):
raise ArgumentTypeError('Path {} does not exist'.format(dp))
raise ArgumentTypeError('Directory {} does not exist'.format(dp))
if not os.path.isfile(os.path.join(dp, 'dotnet')):
raise ArgumentTypeError('Could not find dotnet in {}'.format(dp))
return dp
Expand Down
5 changes: 5 additions & 0 deletions src/benchmarks/micro/ILLink.Descriptors.Serialization.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<linker>
<assembly fullname="System.Private.DataContractSerialization">
<type fullname="System.Runtime.Serialization.DateTimeOffsetAdapter" />
</assembly>
</linker>
2 changes: 2 additions & 0 deletions src/benchmarks/micro/MicroBenchmarks.Wasm.targets
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
</PropertyGroup>

<ItemGroup>
<TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptors.Serialization.xml" />

<_AOT_InternalForceInterpretAssemblies Include="Microsoft.CodeAnalysis.CSharp.dll" />
<_AOT_InternalForceInterpretAssemblies Include="Microsoft.CodeAnalysis.dll" />
</ItemGroup>
Expand Down

0 comments on commit 7586fb5

Please sign in to comment.