Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf Scenarios startup tool build failing #3153

Closed
LoopedBard3 opened this issue Jul 20, 2023 · 6 comments · Fixed by #3159, dotnet/runtime#89323 or #3179
Closed

Perf Scenarios startup tool build failing #3153

LoopedBard3 opened this issue Jul 20, 2023 · 6 comments · Fixed by #3159, dotnet/runtime#89323 or #3179
Assignees
@LoopedBard3
Labels
bug Something isn't working pipeline blocker issue blocks perf pipeline stays green. This be considered high priority.

Comments

@LoopedBard3
Copy link
Member

LoopedBard3 commented Jul 20, 2023 •
edited
Loading

Startup tool build is failing for performance scenarios running on windows. Example error:

D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : You must install or update .NET to run this application. [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : App: D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\bincore\csc.dll [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Architecture: x64 [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Framework: 'Microsoft.NETCore.App', version '8.0.0-preview.7.23368.2' (x64) [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : .NET location: C:\Program Files\dotnet\ [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : You must install or update .NET to run this application. [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : The following frameworks were found: [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :   6.0.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :   6.0.20 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Learn about framework resolution: [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet/app-launch-failed [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : To install missing framework, download: [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-preview.7.23368.2&arch=x64&rid=win10-x64 [D:\a\1\s\src\tools\ScenarioMeasurement\Util\Util.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : App: D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\bincore\csc.dll [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Architecture: x64 [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Framework: 'Microsoft.NETCore.App', version '8.0.0-preview.7.23368.2' (x64) [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : .NET location: C:\Program Files\dotnet\ [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : The following frameworks were found: [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :   6.0.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :   6.0.20 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Learn about framework resolution: [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet/app-launch-failed [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : To install missing framework, download: [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]
D:\a\1\s\CorrelationStaging\dotnet\sdk\8.0.100-rc.1.23370.3\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-preview.7.23368.2&arch=x64&rid=win10-x64 [D:\a\1\s\src\tools\Reporting\Reporting\Reporting.csproj]

I was unable to repro locally, but it only takes a few minutes (<5) to get a pipeline run with the failure.
@LoopedBard3 LoopedBard3 added bug Something isn't working pipeline blocker issue blocks perf pipeline stays green. This be considered high priority. labels Jul 20, 2023
@LoopedBard3 LoopedBard3 self-assigned this Jul 20, 2023
@LoopedBard3
Copy link
Member Author

Still have not been able to repro locally, going to leave for the night to see if there is a transient problem causing the errors.

@cincuranet
Copy link
Contributor

I can't repro locally either. But I think it will settle into place once the versions align again - apparently this took a while to merge.

@LoopedBard3
Copy link
Member Author

This is likely related to dotnet/roslyn#69150.

This was referenced Jul 21, 2023
Merged
Merged
@LoopedBard3 LoopedBard3 reopened this Jul 21, 2023
@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Jul 21, 2023 •
edited
Loading

Keeping open for now to revisit the changes made for this and the DOTNET_ROOT explicit setting once the necessary steps have stabilized. Although with these changes, the scenario pipelines should be running again.

@cincuranet
Copy link
Contributor

Looks like it's running fine again. Care to close this @LoopedBard3?

@LoopedBard3
Copy link
Member Author

Let me check if the long term fix has flown through so we can remove the temp fixes we added.

@LoopedBard3 LoopedBard3 mentioned this issue Jul 27, 2023
Merged
LoopedBard3 added a commit to LoopedBard3/runtime that referenced this issue Jul 31, 2023
@LoopedBard3
Remove now unnecessary fix for building perf tools. Cleaning up per: d…
fe8350c 
…otnet/performance#3153.
@LoopedBard3 LoopedBard3 reopened this Jul 31, 2023
@LoopedBard3 LoopedBard3 mentioned this issue Jul 31, 2023
Merged
LoopedBard3 added a commit to dotnet/runtime that referenced this issue Jul 31, 2023
@LoopedBard3
Remove now unnecessary fix for building perf tools. Cleaning up per: d…
6aa40ab 
…otnet/performance#3153. (#89738)
mthalman pushed a commit to mthalman/dotnet that referenced this issue Aug 11, 2023
@dotnet-maestro
[runtime] Sync e71faee → 749b2d2
88ca842 
Diff: https://github.com/dotnet/runtime/compare/e71faeeeccba29c1f06c7020929cfdadbd32401e..749b2d2f70d8d60834fd8628ed70c694a0a45403

From: dotnet/runtime@e71faee
To: dotnet/runtime@749b2d2

Commits:
  - Update dependencies from https://github.com/dotnet/runtime build 20230731.1 (#89714)
    dotnet/runtime@8622e98
  - [mono][aot] Prefer instances instead of using gsharedvt for types inflated with empty structs. (#89688)
    dotnet/runtime@3769b5e
  - [mono] Disable DllMap on mobile too (#88333)
    dotnet/runtime@f23b644
  - Simplify test DLL lookup logic (#89709)
    dotnet/runtime@e2e24fa
  - [RISC-V] fix Write Barrier (#89716)
    dotnet/runtime@9059941
  - Add JsonContent.Create overloads which accept JsonTypeInfo (#89614)
    dotnet/runtime@7e2eb6b
  - Add file-scoped class trimming test (#89640)
    dotnet/runtime@21f987c
  - Fix EventLog test CanReadAndWriteMessages (#89586)
    dotnet/runtime@fa9ad22
  - Create docs transport package and turn on extensions source of truth (#89312)
    dotnet/runtime@75ecb1a
  - Add handle ownership at creation time for Windows IPC (#89486)
    dotnet/runtime@7b2716b
  - Fix typo in Calendar.cs (#89717)
    dotnet/runtime@8c111a6
  - Fix nongcheap test (#89711)
    dotnet/runtime@7fb4a3c
  - [wasm][debugger] Set VSTEST_TESTHOST_SHUTDOWN_TIMEOUT to 2s (#89703)
    dotnet/runtime@6b6bdf0
  - Fix MSB4120 warning in Microsoft.NETCore.App.Runtime.props (#89723)
    dotnet/runtime@2d1f6ec
  - Remove net7 nuget feeds (#89460)
    dotnet/runtime@0203dcb
  - Move JsonSerializerOptions initialization logic to a shared helper. (#89729)
    dotnet/runtime@045f9d2
  - Gather optimization info through the DAC (#89534)
    dotnet/runtime@e42429e
  - Remove now unnecessary fix for building perf tools. Cleaning up per: dotnet/performance#3153. (#89738)
    dotnet/runtime@6aa40ab
  - Superpmi collect asyncio fix (#89663)
    dotnet/runtime@904ab9a
  - Add top level statement trimming tests (#89606)
    dotnet/runtime@efde006
  [... commit list trimmed ...]

[[ commit created by automation ]]
mthalman pushed a commit to mthalman/dotnet that referenced this issue Aug 11, 2023
@dotnet-maestro
[runtime] Sync e71faee → 749b2d2
0d09d2e 
Diff: https://github.com/dotnet/runtime/compare/e71faeeeccba29c1f06c7020929cfdadbd32401e..749b2d2f70d8d60834fd8628ed70c694a0a45403

From: dotnet/runtime@e71faee
To: dotnet/runtime@749b2d2

Commits:
  - Update dependencies from https://github.com/dotnet/runtime build 20230731.1 (#89714)
    dotnet/runtime@8622e98
  - [mono][aot] Prefer instances instead of using gsharedvt for types inflated with empty structs. (#89688)
    dotnet/runtime@3769b5e
  - [mono] Disable DllMap on mobile too (#88333)
    dotnet/runtime@f23b644
  - Simplify test DLL lookup logic (#89709)
    dotnet/runtime@e2e24fa
  - [RISC-V] fix Write Barrier (#89716)
    dotnet/runtime@9059941
  - Add JsonContent.Create overloads which accept JsonTypeInfo (#89614)
    dotnet/runtime@7e2eb6b
  - Add file-scoped class trimming test (#89640)
    dotnet/runtime@21f987c
  - Fix EventLog test CanReadAndWriteMessages (#89586)
    dotnet/runtime@fa9ad22
  - Create docs transport package and turn on extensions source of truth (#89312)
    dotnet/runtime@75ecb1a
  - Add handle ownership at creation time for Windows IPC (#89486)
    dotnet/runtime@7b2716b
  - Fix typo in Calendar.cs (#89717)
    dotnet/runtime@8c111a6
  - Fix nongcheap test (#89711)
    dotnet/runtime@7fb4a3c
  - [wasm][debugger] Set VSTEST_TESTHOST_SHUTDOWN_TIMEOUT to 2s (#89703)
    dotnet/runtime@6b6bdf0
  - Fix MSB4120 warning in Microsoft.NETCore.App.Runtime.props (#89723)
    dotnet/runtime@2d1f6ec
  - Remove net7 nuget feeds (#89460)
    dotnet/runtime@0203dcb
  - Move JsonSerializerOptions initialization logic to a shared helper. (#89729)
    dotnet/runtime@045f9d2
  - Gather optimization info through the DAC (#89534)
    dotnet/runtime@e42429e
  - Remove now unnecessary fix for building perf tools. Cleaning up per: dotnet/performance#3153. (#89738)
    dotnet/runtime@6aa40ab
  - Superpmi collect asyncio fix (#89663)
    dotnet/runtime@904ab9a
  - Add top level statement trimming tests (#89606)
    dotnet/runtime@efde006
  [... commit list trimmed ...]

[[ commit created by automation ]]
dotnet-bot pushed a commit to dotnet/dotnet that referenced this issue Aug 15, 2023
@dotnet-maestro
[runtime] Sync e71faee → e897946
ec90433 
Diff: https://github.com/dotnet/runtime/compare/e71faeeeccba29c1f06c7020929cfdadbd32401e..e89794659669cb7bb967db73a7ea6889c3891727

From: dotnet/runtime@e71faee
To: dotnet/runtime@e897946

Commits:
  - Update dependencies from https://github.com/dotnet/runtime build 20230731.1 (#89714)
    dotnet/runtime@8622e98
  - [mono][aot] Prefer instances instead of using gsharedvt for types inflated with empty structs. (#89688)
    dotnet/runtime@3769b5e
  - [mono] Disable DllMap on mobile too (#88333)
    dotnet/runtime@f23b644
  - Simplify test DLL lookup logic (#89709)
    dotnet/runtime@e2e24fa
  - [RISC-V] fix Write Barrier (#89716)
    dotnet/runtime@9059941
  - Add JsonContent.Create overloads which accept JsonTypeInfo (#89614)
    dotnet/runtime@7e2eb6b
  - Add file-scoped class trimming test (#89640)
    dotnet/runtime@21f987c
  - Fix EventLog test CanReadAndWriteMessages (#89586)
    dotnet/runtime@fa9ad22
  - Create docs transport package and turn on extensions source of truth (#89312)
    dotnet/runtime@75ecb1a
  - Add handle ownership at creation time for Windows IPC (#89486)
    dotnet/runtime@7b2716b
  - Fix typo in Calendar.cs (#89717)
    dotnet/runtime@8c111a6
  - Fix nongcheap test (#89711)
    dotnet/runtime@7fb4a3c
  - [wasm][debugger] Set VSTEST_TESTHOST_SHUTDOWN_TIMEOUT to 2s (#89703)
    dotnet/runtime@6b6bdf0
  - Fix MSB4120 warning in Microsoft.NETCore.App.Runtime.props (#89723)
    dotnet/runtime@2d1f6ec
  - Remove net7 nuget feeds (#89460)
    dotnet/runtime@0203dcb
  - Move JsonSerializerOptions initialization logic to a shared helper. (#89729)
    dotnet/runtime@045f9d2
  - Gather optimization info through the DAC (#89534)
    dotnet/runtime@e42429e
  - Remove now unnecessary fix for building perf tools. Cleaning up per: dotnet/performance#3153. (#89738)
    dotnet/runtime@6aa40ab
  - Superpmi collect asyncio fix (#89663)
    dotnet/runtime@904ab9a
  - Add top level statement trimming tests (#89606)
    dotnet/runtime@efde006
  [... commit list trimmed ...]

[[ commit created by automation ]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LoopedBard3 LoopedBard3

Labels
bug Something isn't working pipeline blocker issue blocks perf pipeline stays green. This be considered high priority.
Projects
None yet
Milestone
No milestone
2 participants
@cincuranet @LoopedBard3