Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.Caching.Memory.MemoryCache: Initial Benchmarks #1334

Merged
merged 3 commits into from
May 21, 2020

Conversation

NickCraver
Copy link
Member

Creating some benchmarks for planned MemoryCache optimizations we can upstream - first changes in dotnet/runtime#36775. Adding these for all to use, happy to change anything for styling, etc. just tried to match best I knew first pass!

See #462 for context, the lib in here (also: should it point to non-preview?) gets replaced with a dotnet/runtime version if using coreRun, which is awesome.

Nick Craver added 2 commits May 20, 2020 11:55
Creating some benchmarks for planned MemoryCache optimizations we can upstream.
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @NickCraver !

@adamsitnik
Copy link
Member

the CI failure was not related to microbenchmarks so I am merging right now

@adamsitnik adamsitnik merged commit 5db891b into dotnet:master May 21, 2020
@davidfowl
Copy link
Member

Looking forward to fixes here. Lots of low hanging fruit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants