Add Utf8JsonReader.GetBoolean() benchmark #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
reviewed
Nov 18, 2021
| @@ -23,214 +25,189 @@ private static byte[] GetJsonBytes<T>(T elem) | |||
| return Encoding.UTF8.GetBytes(elem.ToString()); | |||
| } | |||
|
|
|||
| [Benchmark] | |||
| public byte GetByte() | |||
| [Benchmark(OperationsPerInvoke = OperationsPerBenchmark)] | |||
There was a problem hiding this comment.
What is the benefit of using OperationsPerInvoke here?
There was a problem hiding this comment.
adamsitnik
requested changes
Nov 19, 2021
There was a problem hiding this comment.
@eiriktsarpalis thank you for your contribution! Please see my comments for full details.
| @@ -23,214 +25,189 @@ private static byte[] GetJsonBytes<T>(T elem) | |||
| return Encoding.UTF8.GetBytes(elem.ToString()); | |||
| } | |||
|
|
|||
| [Benchmark] | |||
| public byte GetByte() | |||
| [Benchmark(OperationsPerInvoke = OperationsPerBenchmark)] | |||
There was a problem hiding this comment.
src/benchmarks/micro/libraries/System.Text.Json/Utf8JsonReader/Perf.Get.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Text.Json/Utf8JsonReader/Perf.Get.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Text.Json/Utf8JsonReader/Perf.Get.cs
Outdated
Show resolved
Hide resolved
adamsitnik
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
GetBoolean()benchmark and simplify existing benchmarks in the same class. Used by dotnet/runtime#61746.