[wasm] Update to build for tfm=net8.0 #2816
Conversation
| <BlazorVersion Condition="'$(AspNetCoreVersion)' == ''">8.0.0-*</BlazorVersion> | ||
| <SystemNetHttpJsonVersion>8.0.0-*</SystemNetHttpJsonVersion> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(TargetFramework)' != 'net8.0'"> |
There was a problem hiding this comment.
Is there a reason to not set net7.0 correctly here and in release/7.0 as well and maybe add a warning for net9?
There was a problem hiding this comment.
I don't know what the existing cases are, or what depends on these older versions, so I went with preserving older behavior except for the cases that I know about.
If there isn't anything depending on this, then we can set it to net7.0, and the blazor, and STJ versions to match.
radical
force-pushed
the
bump-blazor-vers
branch
from
cbf5346
to
6eec7b6
Compare
radical
changed the title
|
/azp run performance-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Without this change, when building for net7/net8, the aspnetcore assemblies were used from 6.0.0 packages.
- generate, and collect binlogs - update to work for linux too
radical
force-pushed
the
bump-blazor-vers
branch
from
d4e8f8a
to
bbcf6cf
Compare
|
I'll add the blazor package versions to the report in a follow up PR. |
|
The failures are known issues. The Windows/micro_net462 will be fixed by #2836 . |
|
|
||
| <PerfLabTargetFrameworksEnvVar Condition="'$(TargetsWindows)' == 'true'">%PERFLAB_TARGET_FRAMEWORKS%</PerfLabTargetFrameworksEnvVar> | ||
| <PerfLabTargetFrameworksEnvVar Condition="'$(TargetsWindows)' != 'true'">%24{PERFLAB_TARGET_FRAMEWORKS}</PerfLabTargetFrameworksEnvVar> | ||
| <PublishArgs>--msbuild "/p:_TrimmerDumpDependencies=true" --msbuild /warnaserror:NU1602,NU1604 --msbuild-static AdditionalMonoLinkerOptions=%27"%24(AdditionalMonoLinkerOptions) --dump-dependencies"%27 --binlog $(LogDirectory)blazor_publish.binlog</PublishArgs> |
There was a problem hiding this comment.
Passing the same arg to python's argparser multiple times has an effect of ignoring all args but the last one. I doubt _TrimmerDumpDependencies=true was set.
E.g. running python3 ./pre.py publish -f net7.0 --readonly-dotnet --has-workload --msbuild "/p:HybridGlobalization=true" --msbuild "/p:RunAOTCompilation=true" --msbuild /warnaserror:NU1602,NU1604 results in:
dotnet publish /workspaces/performance/src/scenarios/blazorpizza/app/BlazingPizza.sln --configuration Release /p:NuGetPackageRoot=/workspaces/performance/artifacts/packages/ /p:RestorePackagesPath=/workspaces/performance/artifacts/packages/ /p:UseSharedCompilation=false /p:BuildInParallel=false /m:1 /p:PublishDir=/workspaces/performance/src/scenarios/blazorpizza/pub --framework net7.0 /warnaserror:NU1602,NU1604 -p:WasmNativeWorkload=false /p:EnableWindowsTargeting=true
and running with e.g. --msbuild "/p:HybridGlobalization=true" --msbuild "/p:RunAOTCompilation=true" results in /p:RunAOTCompilation=true -p:WasmNativeWorkload=false /p:EnableWindowsTargeting=true
blazor_scenariosjob forubuntu