Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BDN #3120

Merged
merged 9 commits into from
Jul 17, 2023
Merged

Update BDN #3120

merged 9 commits into from
Jul 17, 2023

Conversation

cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Jul 11, 2023 •
edited
Loading

  • Update BDN
  • Update version of Microsoft.CodeAnalysis.CSharp in ILLink benchmarks
  • Update ILLink package versions

@cincuranet cincuranet self-assigned this Jul 11, 2023
@cincuranet cincuranet marked this pull request as draft July 11, 2023 16:17
@LoopedBard3 LoopedBard3 mentioned this pull request Jul 12, 2023
Merged
@cincuranet
Copy link
Contributor Author

cincuranet commented Jul 12, 2023 •
edited
Loading

@cincuranet cincuranet marked this pull request as ready for review July 12, 2023 20:00
LoopedBard3
LoopedBard3 previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

LoopedBard3
LoopedBard3 previously approved these changes Jul 13, 2023
View reviewed changes
LoopedBard3
LoopedBard3 previously approved these changes Jul 13, 2023
View reviewed changes
@cincuranet
Copy link
Contributor Author

Currently blocked by dotnet/BenchmarkDotNet#2369.

adamsitnik
adamsitnik reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently blocked by dotnet/BenchmarkDotNet#2369.

I've just merged dotnet/BenchmarkDotNet#2365, there should be a new preview version available in the BDN CI feed in +- 1h.

src/benchmarks/real-world/Roslyn/CompilerBenchmarks.csproj Outdated Show resolved Hide resolved
@cincuranet cincuranet enabled auto-merge (squash) July 17, 2023 19:08
@cincuranet cincuranet mentioned this pull request Jul 17, 2023
Closed
@cincuranet cincuranet merged commit b97f58a into dotnet:main Jul 17, 2023
@cincuranet cincuranet deleted the update-bdn branch July 17, 2023 19:12
@radical radical mentioned this pull request Jul 19, 2023
Merged
@AndyAyersMS AndyAyersMS mentioned this pull request Jul 20, 2023
Closed
@radical radical mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik left review comments

@caaavik-msft caaavik-msft caaavik-msft approved these changes

@LoopedBard3 LoopedBard3 LoopedBard3 left review comments

@sblom sblom Awaiting requested review from sblom

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

Assignees

@cincuranet cincuranet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cincuranet @adamsitnik @LoopedBard3 @caaavik-msft