Adding a build script #33

jorive · 2018-05-22T17:44:08Z

Added build.py (executable)
Updated the src/coreclr/common.props file to suppress .NET Core Preview warnings
Added a script to run src/coreclr benchmarks against CoreCLr's CoreRun
Updated src/coreclr readme

- Added build.py - Updated the `src/coreclr/common.props` file to suppress .NET Core Preview warnings - Added a script to run `src/coreclr` benchmarks against CoreCLr's CoreRun - Updated src/coreclr readme

jorive · 2018-05-22T18:03:32Z

This is the build script help output:

build.py --help

usage: build.py [-h] [-c CONFIGURATION] [-f [FRAMEWORK [FRAMEWORK ...]]] [-v]

Builds the CoreClr benchmarks.

optional arguments:
  -h, --help            show this help message and exit
  -c CONFIGURATION, --configuration CONFIGURATION
                        Configuration use for building the project (default
                        "Debug").
  -f [FRAMEWORK [FRAMEWORK ...]], --frameworks [FRAMEWORK [FRAMEWORK ...]]
                        Target frameworks to publish for (default all).
  -v, --verbose         Turns on verbosity (default "False")
``` #ByDesign

brianrob · 2018-05-22T18:39:45Z

build.py

+ default='Debug',
+ choices=['debug', 'release'],
+ type=str.casefold,
+ help='Configuration use for building the project (default "Debug").',


I think that the default should probably be release since these are perf tests. #Resolved

Makes sense #Resolved

brianrob · 2018-05-22T18:45:08Z

Overall, looks good. In terms of strategy, how are we planning to get from a set of steps that have manual steps right now to something that we can automate? Also, are we planning to start these runs off by running against full SDKs? If so, we shouldn't have to patch anything - we just reference the packages via and should be good to go, right? #Resolved

brianrob

Marking as approved. I don't want to block your merge. :)

jorive · 2018-05-22T20:15:52Z

The plan is to run against the full SDK, but we also want to support running against previous stages of the .NET Core repo-pipeline (this is why I added the support to CoreClr's CoreRun).

In reply to: 391099264 [](ancestors = 391099264)

michellemcdaniel · 2018-05-22T19:52:41Z

build.py

+def get_script_path() -> str:
+ '''Gets this script directory.'''
+ return sys.path[0]
+ # return os.path.dirname(os.path.realpath(__file__))


Probably want to remove this commented out line. #Resolved

michellemcdaniel · 2018-05-22T19:53:03Z

build.py

+ # return os.path.dirname(os.path.realpath(__file__))
+
+
+def get_repo_root_path() -> str:


Is there a reason we need both get_repo_root_path and get_script_path if one just calls the other? #Resolved

I had the script under src/coreclr, but Drew mentioned he could use it, so I moved it to the root. I think this way it is cleaner if we decide to move it under the scripts folder.

In reply to: 190031742 [](ancestors = 190031742)

Gotcha. Makes sense.

michellemcdaniel · 2018-05-22T20:18:12Z

build.py

+ )
+
+
+class DotNet(object):


Can we move some of the classes into their own files? This script is super long with all the class definitions, and it makes it hard to see what is going on. #Resolved

Sure, I can do that.

In reply to: 190038807 [](ancestors = 190038807)

michellemcdaniel · 2018-05-22T20:29:38Z

src/coreclr/run-with-coreclr-corerun.cmd

@@ -0,0 +1,190 @@
+@REM This is a template script to run .NET Performance benchmarks with CoreRun.exe


Are you going to add a shell script version of this as well for linux platforms?

Should we? I had this more as an example than something to be used for automation, so it's clear what needs to be done to run against the CoreClr build.

If we needed I rather convert it to python script. What do you think?

In reply to: 190042328 [](ancestors = 190042328)

I definitely think that if we have a way to run under corerun on windows, we should also for linux platforms. Converting to a python script would be good.

- Added missing annotations - Removed an extra coma on statement - Moved classes to its own file under the build module

michellemcdaniel · 2018-05-23T16:26:21Z

What are the init.py files for? They are all blank

jorive · 2018-05-23T17:24:03Z

@adiaaida Python needs them to treat the folder as a package, and at this moment, I'm not using them (you could have code there too).
UPDATE: It seems that __init__.py files are not needed on python 3.3+
PEP 420 -- Implicit Namespace Packages
I will need to look more into it... Future PR?

DrewScoggins · 2018-05-23T22:26:33Z

scripts/build.py

+ raise FatalError("Unsupported python version.")
+
+ args = process_arguments()
+ configuration, frameworks, verbose = args


Nit: Should probably be verbosity

I was planning to add verbosity to the script for debuggability. This flag was to turn it on/off.
Thoughts?

Given that he has a potential verbosity level option commented out, I feel like the bool of verbose on or off makes sense as verbose, rather than verbosity. Verbosity implies levels.

So the verbose setting that we pass to the publish and restore steps is always the default? Is this just for controlling the verbosity of the script?

-v is only for enable/disable the script verbosity.

Adding a build script

e908338

- Added build.py - Updated the `src/coreclr/common.props` file to suppress .NET Core Preview warnings - Added a script to run `src/coreclr` benchmarks against CoreCLr's CoreRun - Updated src/coreclr readme

jorive requested review from adamsitnik, brianrob, DrewScoggins, michellemcdaniel, AndyAyersMS and valenis May 22, 2018 17:44

brianrob reviewed May 22, 2018

View reviewed changes

brianrob approved these changes May 22, 2018

View reviewed changes

Marking default build to release.

3a077b2

michellemcdaniel reviewed May 22, 2018

View reviewed changes

jorive added 3 commits May 22, 2018 14:12

Removed dead code.

6f72857

Refactor build.py and moved code to a module

eb01ee1

- Added missing annotations - Removed an extra coma on statement - Moved classes to its own file under the build module

Moving build.py into ./scripts/

21fe6ce

DrewScoggins reviewed May 23, 2018

View reviewed changes

Move the coreclr output to its own folder under bin

b8718b4

jorive merged commit 9a0b211 into dotnet:master May 24, 2018

jorive deleted the dev/buildpy branch May 24, 2018 17:16

adamsitnik mentioned this pull request Sep 4, 2020

.NET 5.0 Microbenchmarks Performance Study Report dotnet/runtime#41871

Closed

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a build script #33

Adding a build script #33

jorive commented May 22, 2018

jorive commented May 22, 2018 •

edited

Loading

brianrob May 22, 2018 •

edited by jorive

Loading

jorive May 22, 2018 •

edited

Loading

brianrob commented May 22, 2018 •

edited by jorive

Loading

brianrob left a comment

jorive commented May 22, 2018

michellemcdaniel May 22, 2018 •

edited by jorive

Loading

michellemcdaniel May 22, 2018 •

edited by jorive

Loading

jorive May 22, 2018

michellemcdaniel May 22, 2018

michellemcdaniel May 22, 2018 •

edited by jorive

Loading

jorive May 22, 2018

michellemcdaniel May 22, 2018

jorive May 22, 2018

michellemcdaniel May 22, 2018

michellemcdaniel commented May 23, 2018

jorive commented May 23, 2018 •

edited

Loading

DrewScoggins May 23, 2018 •

edited

Loading

jorive May 23, 2018

michellemcdaniel May 23, 2018

DrewScoggins May 23, 2018

jorive May 24, 2018

		# return os.path.dirname(os.path.realpath(__file__))


		def get_repo_root_path() -> str:

		@@ -0,0 +1,190 @@
		@REM This is a template script to run .NET Performance benchmarks with CoreRun.exe

Adding a build script #33

Adding a build script #33

Conversation

jorive commented May 22, 2018

jorive commented May 22, 2018 • edited Loading

brianrob May 22, 2018 • edited by jorive Loading

Choose a reason for hiding this comment

jorive May 22, 2018 • edited Loading

Choose a reason for hiding this comment

brianrob commented May 22, 2018 • edited by jorive Loading

brianrob left a comment

Choose a reason for hiding this comment

jorive commented May 22, 2018

michellemcdaniel May 22, 2018 • edited by jorive Loading

Choose a reason for hiding this comment

michellemcdaniel May 22, 2018 • edited by jorive Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michellemcdaniel May 22, 2018 • edited by jorive Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michellemcdaniel commented May 23, 2018

jorive commented May 23, 2018 • edited Loading

DrewScoggins May 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorive commented May 22, 2018 •

edited

Loading

brianrob May 22, 2018 •

edited by jorive

Loading

jorive May 22, 2018 •

edited

Loading

brianrob commented May 22, 2018 •

edited by jorive

Loading

michellemcdaniel May 22, 2018 •

edited by jorive

Loading

michellemcdaniel May 22, 2018 •

edited by jorive

Loading

michellemcdaniel May 22, 2018 •

edited by jorive

Loading

jorive commented May 23, 2018 •

edited

Loading

DrewScoggins May 23, 2018 •

edited

Loading