Skip to content

Fix Blazor Inner Loop Client SDK_Scenario #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

LoopedBard3
Copy link
Member

Updated SurveyPrompt.razor file path to Pages as the new blazor wasm template does not have a Shared folder. The template we are using was updated in dotnet/aspnetcore#50554 and had the Shared folder removed resulting in the file copy failing.

@LoopedBard3 LoopedBard3 self-assigned this Dec 8, 2023
@LoopedBard3 LoopedBard3 marked this pull request as ready for review December 8, 2023 21:29
@LoopedBard3 LoopedBard3 added the bug Something isn't working label Dec 8, 2023
@LoopedBard3 LoopedBard3 marked this pull request as draft December 8, 2023 21:37
@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Dec 8, 2023

Reverting to draft as it looks like something is wrong with the results (Time on Thread Diff):

[2023/12/08 20:20:43][INFO] Metric                     |Average        |Min            |Max
[2023/12/08 20:20:43][INFO] ---------------------------|---------------|---------------|---------------
[2023/12/08 20:20:43][INFO] Generic Startup Diff       |2248.850 ms    |1619.433 ms    |3383.947 ms
[2023/12/08 20:20:43][INFO] Generic Startup First Run  |11412.040 ms   |10273.472 ms   |13563.980 ms
[2023/12/08 20:20:43][INFO] Generic Startup Second Run |9163.190 ms    |8553.238 ms    |11266.202 ms
[2023/12/08 20:20:43][INFO] Time on Thread Diff        |-12999.841 ms  |-73151.212 ms  |2660.115 ms

@LoopedBard3
Copy link
Member Author

Made an issue to track this negative value showing up in time on thread diff, but it appears to be rare, especially on dedicated hardware. #3601. Opening for approval.

@LoopedBard3 LoopedBard3 marked this pull request as ready for review December 11, 2023 19:17
@LoopedBard3 LoopedBard3 merged commit f085375 into dotnet:main Dec 12, 2023
@LoopedBard3 LoopedBard3 deleted the FixBlazorInnerLoopClient branch December 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants