Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from the OSX.1015 queues to the OSX.13 queues. #3630

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Dec 15, 2023

Updating from OSX.1015 to OSX.13 includes updating the queue pointed to by the build matrix, updating the XHarnessCLIVersion, and updating the runner to support new changes. The specific runner updates include fixing the log time collection to be based on the time in the previous log + 1, starting with the current time; retrieving and using the device ID in the launch and kill commands, updating the app_pid regex if on iOS 17 or newer, and updating log validation to be more general for new log format.

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2335913&view=results
This should be backwards compatible with the version check, but the OSX.1015 device is not currently being found in the queue. Both devices will be upgraded soon regardless.

Updating from OSX.1015 to OSX.13 includes updating the queue pointed to by the build matrix, updating the XHarnessCLIVersion, and updating the runner to support new changes.
The specific runner updates include fixing the log time collection to be based on the time in the previous log + 1, starting with the current time; retrieving and using the device ID in the launch and kill commands, updating the app_pid regex if on iOS 17 or newer, and updating log validation to be more general for new log format.
@LoopedBard3 LoopedBard3 added the enhancement New feature or request label Dec 15, 2023
@LoopedBard3 LoopedBard3 self-assigned this Dec 15, 2023
Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we maybe want to plug in MicrosoftDotNetXHarnessCLIVersion into Maestro/DARC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants