-
Notifications
You must be signed in to change notification settings - Fork 285
Updated some more perf repo references for net11 #5070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated some more perf repo references for net11 #5070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates references across the performance repository to add support for the net11.0 framework, building upon changes from #4610. The key change is fixing the argparse.ArgumentTypeError: Framework net11.0 is not supported for wasm error in WASM dotnet-runtime-performance pipeline runs.
Key changes:
- Adds net11.0 to supported target frameworks across project files and documentation
- Updates documentation examples to use net11.0 instead of net10.0
- Adds wasmnet11_0 runtime support to fix WASM pipeline errors
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/scenarios/build-common/Blazor.PackageVersions.props | Adds PropertyGroup with package version definitions for net11.0 framework |
| src/benchmarks/micro/README.md | Updates documentation examples to reference net11.0 as the current framework version |
| src/benchmarks/micro/MicroBenchmarks.csproj | Adds net11.0 to the list of supported target frameworks |
| scripts/micro_benchmarks.py | Adds wasmnet11_0 runtime mapping for net11.0 framework to fix WASM pipeline error |
| scripts/ci_setup.py | Adds net10.0 framework handling with global.net10.json file copying |
| global.net10.json | New configuration file defining SDK version and tooling for net10.0 |
Comments suppressed due to low confidence (1)
scripts/ci_setup.py:394
- Missing handling for net11.0 framework. The PR adds net11.0 support throughout the codebase, and similar handling exists for net10.0, net9.0, and net8.0 in lines 381-394. Consider adding a corresponding block to handle net11.0 and nativeaot11.0 frameworks (which would require a global.net11.json file), or verify if net11.0 should intentionally use the default global.json. The 'main' channel in ChannelMap maps to 'net11.0', so this will affect main branch CI runs.
if framework in ('net10.0', 'nativeaot10.0'):
global_json_path = os.path.join(get_repo_root_path(), 'global.json')
shutil.copy(os.path.join(get_repo_root_path(), 'global.net10.json'), global_json_path)
getLogger().info('Overwrote global.json with global.net10.json')
if framework in ('net9.0', 'nativeaot9.0'):
global_json_path = os.path.join(get_repo_root_path(), 'global.json')
shutil.copy(os.path.join(get_repo_root_path(), 'global.net9.json'), global_json_path)
getLogger().info('Overwrote global.json with global.net9.json')
if framework in ('net8.0', 'nativeaot8.0'):
global_json_path = os.path.join(get_repo_root_path(), 'global.json')
shutil.copy(os.path.join(get_repo_root_path(), 'global.net8.json'), global_json_path)
getLogger().info('Overwrote global.json with global.net8.json')
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Should we also add the net10.0 runs in the performance CI as part of this PR? |
|
Yes, that makes sense. Went ahead and added those along with a handful of other changes. |
3b3c6bb to
7fb2ff2
Compare
|
Gave the net10 runs a shot and they were failing due to |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DrewScoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated some more perf repo references based on #4610 for net11.
Mostly consists of adding net11 checks where we already were checking for net10 and updating some net10 defaults to point to net11. A side effect of this includes fixing micro-mono runs in the dotnet-runtime-performance pipeline.
dotnet-runtime-perf test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2858509&view=results.
This does not fix the wasm runs which need a BDN update after BDN adds net11 support for wasm runtime, but it also does not make it worse. Current error from test run: