Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new perf benchmark for generic dictionary expansion #836

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

fadimounir
Copy link

@billwert PTAL

@billwert
Copy link
Member

I’ll take a look when I am back from vacation. Thanks!

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but could you please fix the few small things I've pointed before we merge it?

Thank you!

@fadimounir
Copy link
Author

Thanks for reviewing this @adamsitnik. Should be ready for merging now.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@adamsitnik adamsitnik merged commit 91f0ca4 into dotnet:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants