Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Enable CA1414 for all projects #50

Closed
AArnott opened this issue Nov 12, 2015 · 5 comments
Closed

Enable CA1414 for all projects #50

AArnott opened this issue Nov 12, 2015 · 5 comments

Comments

@AArnott
Copy link
Collaborator

AArnott commented Nov 12, 2015

Per @vbfox's suggestion

@vbfox
Copy link
Collaborator

vbfox commented Nov 12, 2015

After checking it seem that CA1414 is only in FXCop external analysis and still not ported to the new FxCopAnalyzers package so we will have to decide to enable it and when (Only in Release/CI builds or on all builds, knowing that it'll slow down builds)

@AArnott
Copy link
Collaborator Author

AArnott commented Nov 28, 2015

Let's do it: enable Code Analysis on Release builds with at least CA1414 enabled.

Ideally in the process, we consolidate all the .ruleset files to just one or two (for product and test) so we can add/remove rules to apply to all projects.

@arlm
Copy link
Contributor

arlm commented Aug 13, 2016

How can this issue have help? What is in need to be done?

@AArnott
Copy link
Collaborator Author

AArnott commented Aug 13, 2016

Ideally implement the rule in FxCop analyzers then install the package in our projects. But simply enabling legacy FxCop for these projects for this rule would work too.
Thanks.

@AArnott
Copy link
Collaborator Author

AArnott commented Jul 2, 2020

CA1414 still hasn't been ported: dotnet/roslyn-analyzers#430

And I'm actually leaning in the opposite direction, since BOOL is so common and U1 so rare, that perhaps we can just drop all the attributes that explicitly state default behavior.

@AArnott AArnott closed this as completed Jul 2, 2020
AArnott added a commit that referenced this issue Oct 30, 2022
Stop passing $(System.AccessToken) as an arg in AzP
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants