Use NewestImportInput over MSBuildProjectFullPath

Previously the FUTDC would check both the `MSBuildProjectFullPath` (i.e. the current `.csproj` file's path) and the first item of the `MSBuildAllProjects` property, which MSBuild sets to the newest of all imported project files.

As the FUTDC is only interested in the newest input, we only need to check that `MSBuildAllProjects` value and not the `MSBuildProjectFullPath` value. If the project file is newest, it will be covered by `MSBuildAllProjects`. If not, we don't need to check it.

This can save a little time by avoiding a file system check. It also reduces the log output a little.

src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/UpToDate/BuildUpToDateCheck.cs

@@ -304,17 +304,7 @@ bool CheckInputsAndOutputs(IEnumerable<(string Path, string? ItemType, bool IsRe
 
             IEnumerable<(string Path, string? ItemType, bool IsRequired)> CollectDefaultInputs()
             {
-                if (state.MSBuildProjectFullPath is not null)
-                {
-                    log.Verbose(nameof(Resources.FUTD_AddingProjectFileInputs));
-                    using (log.IndentScope())
-                    {
-                        log.VerboseLiteral(state.MSBuildProjectFullPath);
-                    }
-                    yield return (Path: state.MSBuildProjectFullPath, ItemType: null, IsRequired: true);
-                }
-
-                if (state.NewestImportInput is not null && !StringComparers.Paths.Equals(state.NewestImportInput, state.MSBuildProjectFullPath))
+                if (state.NewestImportInput is not null)
                 {
                     log.Verbose(nameof(Resources.FUTD_AddingNewestImportInput));
                     using (log.IndentScope())

src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/UpToDate/UpToDateCheckImplicitConfiguredInput.cs

@@ -22,7 +22,6 @@ public static UpToDateCheckImplicitConfiguredInput CreateDisabled(ProjectConfigu
         {
             return new UpToDateCheckImplicitConfiguredInput(
                 projectConfiguration: projectConfiguration,
-                msBuildProjectFullPath: null,
                 msBuildProjectDirectory: null,
                 projectTargetPath: null,
                 copyUpToDateMarkerItem: null,
@@ -54,15 +53,6 @@ public static UpToDateCheckImplicitConfiguredInput CreateDisabled(ProjectConfigu
         /// </remarks>
         public ProjectConfiguration ProjectConfiguration { get; }
 
-        /// <summary>
-        /// Gets the full path to the project file.
-        /// </summary>
-        /// <remarks>
-        /// Comes from the <c>MSBuildProjectFullPath</c> MSBuild property.
-        /// For example, <c>C:\repos\MySolution\MyProject\MyProject.csproj</c>.
-        /// </remarks>
-        public string? MSBuildProjectFullPath { get; }
-
         /// <summary>
         /// Gets the full path to the project directory.
         /// </summary>
@@ -248,7 +238,6 @@ private UpToDateCheckImplicitConfiguredInput(ProjectConfiguration projectConfigu
 
         private UpToDateCheckImplicitConfiguredInput(
             ProjectConfiguration projectConfiguration,
-            string? msBuildProjectFullPath,
             string? msBuildProjectDirectory,
             string? projectTargetPath,
             string? copyUpToDateMarkerItem,
@@ -271,7 +260,6 @@ private UpToDateCheckImplicitConfiguredInput(
             ProjectCopyData projectCopyData)
         {
             ProjectConfiguration = projectConfiguration;
-            MSBuildProjectFullPath = msBuildProjectFullPath;
             MSBuildProjectDirectory = msBuildProjectDirectory;
             ProjectTargetPath = projectTargetPath;
             CopyUpToDateMarkerItem = copyUpToDateMarkerItem;
@@ -339,7 +327,7 @@ public UpToDateCheckImplicitConfiguredInput Update(
                 return CreateDisabled(ProjectConfiguration);
             }
 
-            string? msBuildProjectFullPath = jointRuleUpdate.CurrentState.GetPropertyOrDefault(ConfigurationGeneral.SchemaName, ConfigurationGeneral.MSBuildProjectFullPathProperty, defaultValue: MSBuildProjectFullPath);
+            string? msBuildProjectFullPath = jointRuleUpdate.CurrentState.GetPropertyOrDefault(ConfigurationGeneral.SchemaName, ConfigurationGeneral.MSBuildProjectFullPathProperty, defaultValue: null);
             string? msBuildProjectDirectory = jointRuleUpdate.CurrentState.GetPropertyOrDefault(ConfigurationGeneral.SchemaName, ConfigurationGeneral.MSBuildProjectDirectoryProperty, defaultValue: MSBuildProjectDirectory);
             string? projectTargetPath = jointRuleUpdate.CurrentState.GetPropertyOrDefault(ConfigurationGeneral.SchemaName, ConfigurationGeneral.TargetPathProperty, defaultValue: "");
             string? projectOutputPath = jointRuleUpdate.CurrentState.GetPropertyOrDefault(ConfigurationGeneral.SchemaName, ConfigurationGeneral.OutputPathProperty, defaultValue: OutputRelativeOrFullPath);
@@ -461,7 +449,6 @@ public UpToDateCheckImplicitConfiguredInput Update(
 
             return new(
                 ProjectConfiguration,
-                msBuildProjectFullPath,
                 msBuildProjectDirectory,
                 projectTargetPath,
                 copyUpToDateMarkerItem: UpdateCopyUpToDateMarkerItem(),
@@ -713,7 +700,6 @@ internal UpToDateCheckImplicitConfiguredInput WithLastItemsChangedAtUtc(DateTime
         {
             return new(
                 ProjectConfiguration,
-                MSBuildProjectFullPath,
                 MSBuildProjectDirectory,
                 ProjectTargetPath,
                 CopyUpToDateMarkerItem,
@@ -740,7 +726,6 @@ public UpToDateCheckImplicitConfiguredInput WithRestoredState(int itemHash, Date
         {
             return new(
                 ProjectConfiguration,
-                MSBuildProjectFullPath,
                 MSBuildProjectDirectory,
                 ProjectTargetPath,
                 CopyUpToDateMarkerItem,

src/Microsoft.VisualStudio.ProjectSystem.Managed/Resources.resx

@@ -296,9 +296,6 @@ This project was loaded using the wrong project type, likely as a result of rena
     <value>In Set="{4}", no inputs are newer than earliest output '{0}' ({1}). Newest input is '{2}' ({3}).</value>
     <comment>Do not translate 'Set' as this name is used in code. {0} and {2} are file paths. {1} and {2} are datetimes. {4} is the name of the set.</comment>
   </data>
-  <data name="FUTD_AddingProjectFileInputs" xml:space="preserve">
-    <value>Adding project file inputs:</value>
-  </data>
   <data name="FUTD_AddingNewestImportInput" xml:space="preserve">
     <value>Adding newest import input:</value>
   </data>