Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove concept of "short name" in TargetFramework #2795

Closed
davkean opened this issue Sep 7, 2017 · 2 comments · Fixed by #9008
Closed

Remove concept of "short name" in TargetFramework #2795

davkean opened this issue Sep 7, 2017 · 2 comments · Fixed by #9008
Assignees
@drewnoakes
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Milestone
17.x

Comments

@davkean
Copy link
Member

davkean commented Sep 7, 2017 •
edited by drewnoakes
Loading

TargetFramework has a short name concept - this has been fraught with bugs #2713 and #2388 because it's really tempting to compare it. Short name is not-canonical and should never be compared, it is solely a convenience used for developers writing project files.

We should remove concept of TargetFramework.ShortName.
@davkean davkean self-assigned this Sep 7, 2017
@davkean davkean added the Bug label Sep 7, 2017
@davkean davkean added this to the 15.5 milestone Sep 7, 2017
@Pilchie Pilchie modified the milestones: 15.5, 15.6 Oct 17, 2017
@davkean davkean mentioned this issue Nov 30, 2017
Merged
@Pilchie Pilchie modified the milestones: 15.6, 15.7 Jan 10, 2018
@Pilchie Pilchie modified the milestones: 15.7, 15.8 Apr 16, 2018
@davkean davkean modified the milestones: 15.8, 16.0 May 23, 2018
@davkean davkean mentioned this issue Dec 11, 2018
Merged
@jjmew jjmew modified the milestones: 16.0, 16.X Feb 13, 2019
@drewnoakes drewnoakes mentioned this issue May 30, 2019
Closed
@davkean davkean assigned drewnoakes and unassigned davkean Feb 10, 2020
@davkean davkean added the Triage-Approved Reviewed and prioritized label Feb 10, 2020
@davkean davkean added this to the 16.7 milestone Feb 10, 2020
@drewnoakes drewnoakes added the Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references label Feb 13, 2020
@drewnoakes
Copy link
Member

Currently we use the short form in dependency ID strings. Using the long form will increase memory consumption.

Blocking this on #5051.

@drewnoakes drewnoakes added the Blocked This issue is blocked from making progress due to another issue. label Mar 30, 2020
@drewnoakes drewnoakes modified the milestones: 16.7, 16.8 May 12, 2020
@drewnoakes drewnoakes mentioned this issue May 12, 2020
Closed
@drewnoakes drewnoakes modified the milestones: 16.8, 16.9 Jul 24, 2020
@drewnoakes
Copy link
Member

#5051 has been addressed, unblocking this.

TargetFramework.FrameworkName was removed in dfc437c, leaving only properties FullName and ShortName. When we remove ShortName, we may be able to remove TargetFramework altogether.

@drewnoakes drewnoakes removed the Blocked This issue is blocked from making progress due to another issue. label Jul 24, 2020
@drewnoakes drewnoakes modified the milestones: 16.9, 16.10 Nov 23, 2020
@drewnoakes drewnoakes mentioned this issue Jan 13, 2021
Closed
@drewnoakes drewnoakes modified the milestones: 16.10, 17.0 May 11, 2021
@drewnoakes drewnoakes modified the milestones: 17.0, 17.1 Aug 10, 2021
@drewnoakes drewnoakes modified the milestones: 17.1, 17.x Nov 19, 2021
@drewnoakes drewnoakes mentioned this issue Mar 31, 2023
Closed
@drewnoakes drewnoakes mentioned this issue May 10, 2023
Merged
@ghost ghost added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label May 16, 2023
@drewnoakes drewnoakes removed the Bug label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewnoakes drewnoakes

Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. Triage-Approved Reviewed and prioritized
Projects
None yet
Milestone
17.x
Development

Successfully merging a pull request may close this issue.

Rewrite dependencies tree drewnoakes/project-system
4 participants
@Pilchie @drewnoakes @davkean @jjmew