-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Dataflow and snapshots for dependencies node data processing #6183
Labels
Feature-Dependency-Node
"Dependencies" node in Solution Explorer that display project, binary & package references
Resolution-Fixed
The bug has been fixed, refer to the milestone to see in which release it was fixed.
Tracking
Tracking a bug against another repo or a larger thematic issue tracking a group of work.
Triage-Approved
Reviewed and prioritized
Milestone
Comments
drewnoakes
added
Tracking
Tracking a bug against another repo or a larger thematic issue tracking a group of work.
Feature-Dependency-Node
"Dependencies" node in Solution Explorer that display project, binary & package references
labels
May 12, 2020
This was referenced May 12, 2020
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this issue
May 19, 2020
Fixes dotnet#6204 Fixes AB#1126588 We are seeing some customer NFEs around this check. The validation is theoretically correct, but the consequences of continuing in such a scenario are minor-to-non-existant. Therefore I'm leaving it as an assert to assist during development of this code. This code would likely disappear as part of dotnet#6183
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this issue
May 19, 2020
Fixes dotnet#6204 Fixes AB#1126588 We are seeing some customer NFEs around this check. The validation is theoretically correct, but the consequences of continuing in such a scenario are minor-to-non-existant. Therefore I'm leaving it as an assert to assist during development of this code. This code would likely disappear as part of dotnet#6183
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this issue
May 19, 2020
Fixes dotnet#6204 Fixes AB#1126588 We are seeing some customer NFEs around this check where the active target framework is "Unsupported,Version=v0.0". The validation is theoretically correct, but the consequences of continuing in such a scenario are minor-to-non-existant. Therefore I'm leaving it as an assert to assist during development of this code. The real fix for this problem would be covered by dotnet#6183.
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this issue
Jan 11, 2021
The removed validation in is sound in theory, however is causing quite a few NFEs. For example dotnet#6656. This commit disables it for now. The consequence of this test failing is that dependencies added to the tree are not exposed via extensibility APIs such as DTE/VSLangProj. At some point we should revisit how the dependencies tree models its target frameworks, likely as part of dotnet#6183.
ghost
added
the
Resolution-Fixed
The bug has been fixed, refer to the milestone to see in which release it was fixed.
label
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature-Dependency-Node
"Dependencies" node in Solution Explorer that display project, binary & package references
Resolution-Fixed
The bug has been fixed, refer to the milestone to see in which release it was fixed.
Tracking
Tracking a bug against another repo or a larger thematic issue tracking a group of work.
Triage-Approved
Reviewed and prioritized
The processing of data through the Dependencies node code has a few issues that I'd like to address in a batch, potentially in 16.8:
IProjectDependenciesSubTreeProvider
and internalIDependencyCrossTargetSubscriber
) where there should only be oneThe concept of 'filters' should be removedIDependencyCrossTargetSubscriber
,AggregateCrossTargetProjectContext
,AggregateCrossTargetProjectContextProvider
UnwrapCollectionChainedProjectValueDataSource
The work is mostly self-contained within this repo, however it will also require synchronising changes with the WebTools team for NPM dependencies.
The text was updated successfully, but these errors were encountered: