Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing last dependency of a IProjectDependenciesSubTreeProvider can leave empty group node in tree #9227

Closed
drewnoakes opened this issue Aug 15, 2023 · 0 comments · Fixed by #9228
Assignees
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Regression Regressions from a previous (typically public) build or release. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed.
Milestone

Comments

@drewnoakes
Copy link
Member

Visual Studio Version

17.7

Summary

When extending the dependency tree via IProjectDependenciesSubTreeProvider, if the last dependency within that extender's group is removed, the group node remains with no children. In 17.6, the group would be removed.

This is a subtle behaviour regression stemming from the rewrite in #9008.

This was reported by FireGiant with the following example:

After adding “MyLibrary”.

image

If we delete “MyLibrary”, we used to see the “WiX Libraries” group node also deleted prior to 17.7, but instead it remains, like this:

image

@drewnoakes drewnoakes added Regression Regressions from a previous (typically public) build or release. Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references labels Aug 15, 2023
@drewnoakes drewnoakes added this to the 17.8 milestone Aug 15, 2023
@drewnoakes drewnoakes self-assigned this Aug 15, 2023
@ghost ghost added the Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed. label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Dependency-Node "Dependencies" node in Solution Explorer that display project, binary & package references Regression Regressions from a previous (typically public) build or release. Resolution-Fixed The bug has been fixed, refer to the milestone to see in which release it was fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant