Fix empty dependency group node for external dependencies #9228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementations of the `IProjectDependenciesSubTreeProvider` interface may extend the dependencies tree with additional dependency types. The rewrite in 17.7 introduced a subtle change in bevahiour where removing the last dependency in a group added via this interface would leave the group node visible in the tree. This change ensures we remove the group altogether when the last item is removed.
drewnoakes
added
the
Feature-Dependency-Node
smitpatel
approved these changes
Aug 15, 2023
haileymck
approved these changes
Aug 15, 2023
melytc
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9227
Implementations of the
IProjectDependenciesSubTreeProviderinterface may extend the dependencies tree with additional dependency types.The rewrite in 17.7 introduced a subtle change in bevahiour where removing the last dependency in a group added via this interface would leave the group node visible in the tree.
This change ensures we remove the group altogether when the last item is removed.
Microsoft Reviewers: Open in CodeFlow