Config properties #1591
Closed
Config properties #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 17, 2017 18:27
…e provider to the configuration property.
…operty so that it can property override values that initially come from targets or props.
…/Platforms properties in the project
mavasani
reviewed
Feb 22, 2017
| namespace Microsoft.VisualStudio.ProjectSystem.VS.Configuration | ||
| { | ||
| [ProjectSystemTrait] | ||
| public class ConfigurationConfigurationProjectConfigurationDimensionProviderTest |
| /// </summary> | ||
| /// <param name="args">Information about the configuration dimension value change.</param> | ||
| /// <returns>A task for the async operation.</returns> | ||
| public override async Task OnDimensionValueChangedAsync(ProjectConfigurationDimensionValueChangedEventArgs args) |
There was a problem hiding this comment.
This seems a bit convoluted to me - each provider is responsible for writing out the updated values to the MSBuild project file?
There was a problem hiding this comment.
Correct, that's one of the downsides of adding an extensibility point with full control. To make things even more interesting, add/remove need to be saved at different times than rename due to the order of operations on the CPS side.
| /// </summary> | ||
| [Export(typeof(IProjectConfigurationDimensionsProvider2))] | ||
| [AppliesTo(ProjectCapabilities.ProjectConfigurationsDeclaredDimensions)] | ||
| [Order(int.MaxValue -1)] |
There was a problem hiding this comment.
Please add a comment about the order attribute value in all providers.
| await OnConfigurationRenamed(args.Project, args.OldDimensionValue, args.DimensionValue).ConfigureAwait(true); | ||
| } | ||
|
|
||
| // await _projectXmlAccessor.ExecuteInWriteLock((msbuildProject) => msbuildProject.Save()).ConfigureAwait(true); |
There was a problem hiding this comment.
Oops, I was trying to see if I could work around another issue and forgot to delete this.
This was referenced Mar 16, 2017
|
See #1771 for updated PR post merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on the CPS changes that haven't been checked in yet, https://mseng.visualstudio.com/VSIDEProj/_git/VSIDEProj.CPS/pullrequest/186915?_a=overview
It implements dimension providers for configuration and platform based on 'Configurations' and 'Platforms' project property.
There are still 2 issues I'm investigating in the scenario but those appear to be existing issues as I'm hitting them without any changes in either CPS or the project system.
There will also a follow up PR on the SDK as the defaults will be set there