Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warnaserror work from the property pages. #2368

Merged
merged 2 commits into from
Jun 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@
<BoolProperty Name="Optimize" DisplayName="Optimize" Visible="False"/>
<StringProperty Name="NoWarn" DisplayName="Supress Warning" Visible="False"/>
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Treat warnings as errors" Visible="False"/>
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Treat specific warnings as errors" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Treat specific warnings as errors" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Output Path" Visible="False"/>
<StringProperty Name="DocumentationFile" DisplayName="Documentation file" Visible="False"/>
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Generate serialization assemblies" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
Visible="False"
ReadOnly="True" />

<StringProperty Name="TreatSpecificWarningsAsErrors"
<StringProperty Name="WarningsAsErrors"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to send both properties to NuGet? What if someone specifically enters <TreatSpecificWarningsAsErrors>NU1000</TreatSpecificWarningsAsErrors>? Or do we need to deprecate that because it will not be reflected in the property page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya TreatSpecificWarningsAsErrors is not a property that has meant anything to anyone in the past. It looks like the DTE property is called that and so we just had a StringProperty with that same name by mistake. The only projects that will have this are ones where someone tried to set WarnAsError from the proppages and it wouldn't have worked. So its dead code in their project files. I don't see any reason to support both.

Copy link
Contributor

@natidea natidea Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we should update the NuGet spec at https://github.com/NuGet/Home/wiki/Improved-NuGet-warnings to use <WarningsAsErrors> in Scenario-1, step 5
/cc @anangaur

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should. Tagging @emgarten again to make sure that the implementation does that.

Visible="False"
ReadOnly="True" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Optimalizovat" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Potlačit upozornění" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Zpracovávat upozornění jako chyby" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Považovat specifická upozornění za chyby" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Považovat specifická upozornění za chyby" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Výstupní cesta" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Soubor dokumentace" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Generovat serializované sestavení" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Optimieren" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Warnung unterdrücken" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Warnungen als Fehler behandeln" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Spezifische Warnungen als Fehler behandeln" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Spezifische Warnungen als Fehler behandeln" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Ausgabepfad" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Dokumentationsdatei" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Serialisierungsassemblys generieren" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Optimizar" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Suprimir advertencia" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Tratar advertencias como errores" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Tratar advertencias específicas como errores" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Tratar advertencias específicas como errores" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Ruta de acceso de salida" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Archivo de documentación" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Generar ensamblados de serialización" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Optimiser" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Supprimer l'avertissement" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Considérer les avertissements comme des erreurs" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Considérer les avertissements spécifiques comme des erreurs" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Considérer les avertissements spécifiques comme des erreurs" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Chemin de sortie" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Fichier de documentation" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Générer des assemblys de sérialisation" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Ottimizza" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Non visualizzare l'avviso" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Considera gli avvisi come errori" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Considera avvisi specifici come errori" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Considera avvisi specifici come errori" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Percorso di output" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="File di documentazione" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Genera assembly di serializzazione" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="最適化" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="警告を抑制する" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="警告をエラーとして扱う" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="特定の警告をエラーとして扱う" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="特定の警告をエラーとして扱う" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="出力パス" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="ドキュメント ファイル" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="シリアル化アセンブリの生成" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="최적화" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="경고 표시 안 함" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="경고를 오류로 처리" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="특정 경고를 오류로 처리" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="특정 경고를 오류로 처리" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="출력 경로" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="문서 파일" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Serialization 어셈블리 생성" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Optymalizuj" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Pomiń ostrzeżenie" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Traktuj ostrzeżenia jako błędy" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Traktuj konkretne ostrzeżenia jako błędy" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Traktuj konkretne ostrzeżenia jako błędy" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Ścieżka wyjściowa" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Plik dokumentacji" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Generuj zestawy serializacji" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Otimizar" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Suprimir Aviso" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Tratar avisos como erros" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Tratar avisos específicos como erros" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Tratar avisos específicos como erros" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Caminho de Saída" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Arquivo de documentação" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Gerar assemblies de serialização" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="Оптимизировать" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Отключить предупреждение" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Обрабатывать предупреждения как ошибки" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Интерпретировать указанные предупреждения как ошибки" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Интерпретировать указанные предупреждения как ошибки" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Выходной путь" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Файл документации" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Создать сборки сериализации" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="İyileştir" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="Uyarıyı Gösterme" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="Uyarıları hata olarak değerlendir" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Belirli uyarıları hata olarak değerlendir" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="Belirli uyarıları hata olarak değerlendir" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="Çıkış Yolu" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="Belge dosyası" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="Serileştirme bütünleştirilmiş kodları oluştur" Visible="False">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
<StringProperty Name="RestoreFallbackFolders" Visible="False" ReadOnly="True" />
<StringProperty Name="RestorePackagesPath" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="WarningsAsErrors" Visible="False" ReadOnly="True" />
<StringProperty Name="NoWarn" Visible="False" ReadOnly="True" />
</Rule>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
<BoolProperty Name="Optimize" DisplayName="优化" Visible="False" />
<StringProperty Name="NoWarn" DisplayName="取消警告" Visible="False" />
<BoolProperty Name="TreatWarningsAsErrors" Default="False" Description="将警告视为错误" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="将特定的警告视为错误" Visible="False" />
<StringProperty Name="TreatSpecificWarningsAsErrors" Description="将特定的警告视为错误" Visible="False">
<StringProperty.DataSource>
<DataSource Persistence="ProjectFile" PersistedName="WarningsAsErrors" />
</StringProperty.DataSource>
</StringProperty>
<StringProperty Name="OutputPath" DisplayName="输出路径" Visible="False" />
<StringProperty Name="DocumentationFile" DisplayName="文档文件" Visible="False" />
<EnumProperty Name="GenerateSerializationAssemblies" DisplayName="生成序列化程序集" Visible="False">
Expand Down
Loading