Fix NRE due to dataflow race #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible for ProcessProjectChanged to be called before _broadcastBlock was assigned, leading to a NRE when it was dereferenced.
davidwengier
approved these changes
Jul 10, 2019
tmeschter
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a NRE due to a dataflow race condition in
PotentialEditorConfigDataSource.It was possible for
ProcessProjectChangedto be called before_broadcastBlockwas assigned, leading to a NRE when it was dereferenced.This exception has been fixed indirectly in
mastervia 2894df4 so does not need to be integrated forward. This PR prevents it happening in 16.3 preview 1.@tmeschter @jmarolf @jjmew