Idempotent change won't mark dependency unresolved #7990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementations of these methods are identical.
Previously, any evaluation of the project that changed a dependency would mark it as unresolved until the build data arrives. Some kinds of changes trigger a change in evaluation that is not accompanied by a corresponding change in build data. The evaluation update would set the dependency to unresolved, expecting the build to resolve it. Yet the build delta would exist and so the dependency would be left unresolved. The change in this commit remembers the set of resolved references. When an evaluation occurs, we do not mark a known-resolved dependency as unresolved. If the build does not trigger a change, then the dependency remains in the correct state.
drewnoakes
added
the
Feature-Dependency-Node
ghost
added
the
Tenet-User Friendly
|
This also fixes #5356, where renaming the project would force dependencies to become unresolved. |
MiYanni
approved these changes
Mar 22, 2022
...ed/ProjectSystem/Tree/Dependencies/Subscriptions/RuleHandlers/DependenciesRuleHandlerBase.cs
Outdated
Show resolved
Hide resolved
...ed/ProjectSystem/Tree/Dependencies/Subscriptions/RuleHandlers/DependenciesRuleHandlerBase.cs
Show resolved
Hide resolved
...tem.Managed/ProjectSystem/Tree/Dependencies/Subscriptions/RuleHandlers/PackageRuleHandler.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2510
Fixes #5356
Previously, any evaluation of the project that changed a dependency would mark it as unresolved until the build data arrives.
Some kinds of changes trigger a change in evaluation that is not accompanied by a corresponding change in build data. The evaluation update would set the dependency to unresolved, expecting the build to resolve it. Yet the build delta would exist and so the dependency would be left unresolved.
The changes in this PR cause the tree to remember the set of resolved references. When an evaluation occurs, we do not mark a known-resolved dependency as unresolved. If the build does not trigger a change, then the dependency remains in the correct state.
There are some cleanups in separate commits. The main change is in 9859b6f.
Before
After
Microsoft Reviewers: Open in CodeFlow