Add dataflow block name and some API docs #8617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
added
the
Feature-Language-Service
tmeschter
approved these changes
Oct 18, 2022
| @@ -132,7 +132,8 @@ protected override async Task InitializeCoreAsync(CancellationToken cancellation | |||
| target: DataflowBlockFactory.CreateActionBlock<IProjectVersionedValue<(ConfiguredProject ActiveConfiguredProject, ConfigurationSubscriptionSources Sources)>>( | |||
| async update => await ExecuteUnderLockAsync(cancellationToken => OnSlicesChanged(update, cancellationToken)), | |||
| _unconfiguredProject, | |||
| ProjectFaultSeverity.LimitedFunctionality), | |||
| ProjectFaultSeverity.LimitedFunctionality, | |||
| "LanguageServiceHostSlices {0}"), | |||
There was a problem hiding this comment.
What fills in the place holder here, and what value will it have?
There was a problem hiding this comment.
I've only ever seen it used in WinDBG, to help identify the purpose behind each dataflow block in the graph. I'm not sure what value goes in the placeholder actually, or why it's needed, but all nameFormat values have that.
There was a problem hiding this comment.
Digging into this, the nameFormat is used on the dataflow block's ToString method, and is passed two placeholder values:
{0}— the block's type name{1}— the hash code of the block
MiYanni
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #8550 to simplify review.
Microsoft Reviewers: Open in CodeFlow