-
Notifications
You must be signed in to change notification settings - Fork 408
Build DotNetDeltaApplier and BrowserRefresh dependencies using source packages #9822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmat
wants to merge
6
commits into
dotnet:main
Choose a base branch
from
tmat:TraceLoggingMain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−78
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f082dac
Disable Trace level log messages
tmat 3281dba
Update to latest Hot Reload packages.
tmat 5f37b37
Use .NET 10
tmat 5134914
Workaround for PDB conversion issues
tmat f3800f6
Remove unnecessary package refs
tmat a3ccd7d
Fx
tmat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "sdk": { | ||
| // necessary for VS to find pre-release SDKs | ||
| "allowPrerelease": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <Project> | ||
| <!-- | ||
| Assemblies that facilitate Hot Reload within the application process. | ||
| When updating TFMs here also update ProjectHotReloadSession.GetStartupHookPath and VisualStudioBrowserRefreshServer.MiddlewareTargetFramework. | ||
| --> | ||
| <ItemGroup> | ||
tmat marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <ProjectReference Include="$(MSBuildThisFileDirectory)Microsoft.AspNetCore.Watch.BrowserRefresh\Microsoft.AspNetCore.Watch.BrowserRefresh.csproj"> | ||
| <OutputItemType>Content</OutputItemType> | ||
| <SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties> | ||
| <ReferenceOutputAssembly>false</ReferenceOutputAssembly> | ||
| <UndefineProperties>TargetFramework;TargetFrameworks</UndefineProperties> | ||
| <VSIXSubPath>HotReload\net6.0</VSIXSubPath> | ||
| <TargetPath>HotReload\net6.0\Microsoft.AspNetCore.Watch.BrowserRefresh.dll</TargetPath> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </ProjectReference> | ||
|
|
||
| <ProjectReference Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.DotNetDeltaApplier\Microsoft.Extensions.DotNetDeltaApplier.csproj"> | ||
| <OutputItemType>Content</OutputItemType> | ||
| <SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties> | ||
| <ReferenceOutputAssembly>false</ReferenceOutputAssembly> | ||
| <SetTargetFramework>TargetFramework=net10.0</SetTargetFramework> | ||
| <VSIXSubPath>HotReload\net10.0</VSIXSubPath> | ||
| <TargetPath>HotReload\net10.0\Microsoft.Extensions.DotNetDeltaApplier.dll</TargetPath> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </ProjectReference> | ||
|
|
||
| <ProjectReference Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.DotNetDeltaApplier\Microsoft.Extensions.DotNetDeltaApplier.csproj"> | ||
| <OutputItemType>Content</OutputItemType> | ||
| <SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties> | ||
| <ReferenceOutputAssembly>false</ReferenceOutputAssembly> | ||
| <SetTargetFramework>TargetFramework=net6.0</SetTargetFramework> | ||
| <VSIXSubPath>HotReload\net6.0</VSIXSubPath> | ||
| <TargetPath>HotReload\net6.0\Microsoft.Extensions.DotNetDeltaApplier.dll</TargetPath> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </ProjectReference> | ||
| </ItemGroup> | ||
| </Project> | ||
32 changes: 32 additions & 0 deletions
32
...icrosoft.AspNetCore.Watch.BrowserRefresh/Microsoft.AspNetCore.Watch.BrowserRefresh.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <!-- | ||
| This assembly may be loaded .NET 6.0+ web server. | ||
| When updating the TFM also update minimal supported version in VisualStudioBrowserRefreshServer. | ||
| --> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
|
|
||
| <!-- Workaround issues with Pdb2Pdb conversion: the assembly does not load to any VS process --> | ||
| <DebugType>embedded</DebugType> | ||
| <PublishWindowsPdb>false</PublishWindowsPdb> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.DotNet.HotReload.Web.Middleware" PrivateAssets="all" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Using Remove="@(Using)"/> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Update="@(Compile)"> | ||
| <Link Condition="'%(NuGetPackageId)' != ''">%(NuGetPackageId)\%(Link)</Link> | ||
| </Compile> | ||
| </ItemGroup> | ||
| </Project> |
35 changes: 35 additions & 0 deletions
35
src/Microsoft.Extensions.DotNetDeltaApplier/Microsoft.Extensions.DotNetDeltaApplier.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <!-- | ||
| dotnet-watch may inject this assembly to .NET 6.0+ app. | ||
|
|
||
| When updating these also update ProjectHotReloadSession. | ||
| --> | ||
| <TargetFrameworks>net6.0;net10.0</TargetFrameworks> | ||
|
|
||
| <!-- Suppress warning: Microsoft.Bcl.AsyncInterfaces 9.0.0 doesn't support net6.0 and has not been tested with it. --> | ||
| <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> | ||
|
|
||
| <!-- Workaround issues with Pdb2Pdb conversion: the assembly does not load to any VS process --> | ||
| <DebugType>embedded</DebugType> | ||
| <PublishWindowsPdb>false</PublishWindowsPdb> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.DotNet.HotReload.Agent" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.DotNet.HotReload.Agent.Data" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.DotNet.HotReload.Agent.Host" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.DotNet.HotReload.Agent.PipeRpc" PrivateAssets="all" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Using Remove="@(Using)"/> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Update="@(Compile)"> | ||
| <Link Condition="'%(NuGetPackageId)' != ''">%(NuGetPackageId)\%(Link)</Link> | ||
| </Compile> | ||
| </ItemGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.