This repository was archived by the owner on Sep 26, 2024. It is now read-only.
Stop Eating Optional ; after @typeparam#36
Merged
TanayParikh merged 3 commits intomainfrom Jan 21, 2022
Merged
Conversation
pranavkm
reviewed
Jan 20, 2022
pranavkm
approved these changes
Jan 20, 2022
ryanbrandenburg
approved these changes
Jan 21, 2022
Contributor
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
I still don't really understand the cspans files or why all those .mappings.txt's changed, but it seems the the ";" is now included in .stree.txt and the verifier doesn't fail so we know the SyntaxTree length should be correct, so I'm happy.
TanayParikh
added a commit
that referenced
this pull request
Jan 25, 2022
* Add Razor Directive Tests * Stop eating token * Baseline updates (cherry picked from commit 848e96c)
TanayParikh
added a commit
that referenced
this pull request
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd implemented optional
;for@typeparamhowever by eating the token we were causing issues with the syntax tree. @ryanbrandenburg provided a failing test so implemented this fix accordingly.Fixes: dotnet/aspnetcore#39616