This repository was archived by the owner on Sep 26, 2024. It is now read-only.
Avoid globally qualifying user defined types #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
commented
Feb 3, 2022
| pb.SetPropertyName(property.Name); | ||
| pb.IsEditorRequired = property.GetAttributes().Any(a => a.AttributeClass.ToDisplayString() == "Microsoft.AspNetCore.Components.EditorRequiredAttribute"); | ||
|
|
||
| pb.SetGloballyQualifiedTypeName(property.Type.ToDisplayString(GloballyQualifiedFullNameTypeDisplayFormat)); |
Member
Author
There was a problem hiding this comment.
The key is here, where we capture the globally qualified type name for the type. This comes from the symbol, and we re-use it later on.
pranavkm
reviewed
Feb 3, 2022
src/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentNodeWriter.cs
Outdated
Show resolved
Hide resolved
javiercn
commented
Feb 3, 2022
| candidate = candidate.Left as QualifiedNameSyntax; | ||
| } | ||
| return false; | ||
| } |
Member
Author
There was a problem hiding this comment.
This rewriter needs to account for the fact that the types might already be globally qualified
pranavkm
approved these changes
Feb 3, 2022
javiercn
commented
Feb 3, 2022
| // the type name. | ||
| if (!globallyQualifiedTypeName.StartsWith("global::", StringComparison.Ordinal)) | ||
| { | ||
| attribute.Annotations.Add(ComponentMetadata.Component.ExplicitTypeNameKey, true); |
Member
Author
There was a problem hiding this comment.
We use this metadata to signal that we replaced something like TItem with potential user input, like MyType (which we can't qualify) to avoid prepending global:: incorrectly.
TanayParikh
approved these changes
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#39950