This repository was archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Support @bind:get, @bind:set, @bind:after #70
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
ed7692a
Initial support for 'bind:after' in elements
javiercn d4b1225
Support @bind:get and @bind:set
javiercn 3fe7011
Baselines
javiercn 9b5bc10
Align code generation with runtime
javiercn d2f775b
tmp
javiercn 61d078e
Fix tests and update baselines
javiercn addd707
Code generation for component bindings
javiercn f88b09c
Fixes
javiercn beefae6
Make component bindings work
javiercn 3d42627
Code generation fixes
javiercn ad8d836
Get set after baselines
javiercn 0713ea4
Update other baselines
javiercn 48530b1
Update runtime helpers and update code gen
javiercn 770c516
update baselines
javiercn 2214496
Add additional tests for checking errors
javiercn c44cb60
Add baselines for error cases
javiercn 9da42b2
renames and test fixes
javiercn 72f199f
Cleanups
javiercn 2dffd55
Add additional test asserts for the new parameters
javiercn d2d4b4d
Remove unnecessary change to ComponentAttributeIntermediateNode and u…
javiercn ac02503
Fix bad refactoring
javiercn 39483c8
Undo accidental test renames
javiercn fab5b4e
Fix baselines
javiercn 473432c
Fix incorrect 'async' added to a method
javiercn c44b5aa
Fix regression
javiercn dc35dcc
Clarifying comment
javiercn cfe3530
Add version 7.0 to RazorLanguageVersion, check for Version 7.0 for bi…
javiercn 2441c43
Update src/Microsoft.AspNetCore.Razor.Language/src/Components/Compone…
javiercn feb4d63
Update baseline
javiercn 7151eb5
Unskip test
javiercn 0f2c6cd
Add tests to cover generics and type inference
javiercn eaab3d6
Update the Razor Language Version on the SDK
javiercn a8ed31c
Update baselines
javiercn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
410 changes: 342 additions & 68 deletions
410
src/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentBindLoweringPass.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be interested to see how these helpers will look (e.g., their range of overloads). Does that info exist anywhere yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/dotnet/aspnetcore/pull/40143/files#diff-75ff7c1daf5ea067e9a29e6ddba5450cf62daab8ff131de1ed77bd2816478de7R55-R126