Remove Hover Handler Silent Failure (#1832)

The Roslyn C# and WTE HTML hover handler `textDocument/hover` endpoints are now available. VSLanguageServer support for multiple hover handlers has also been enabled. Removing the temporary silent failure. Fixes dotnet/aspnetcore#20962
dotnet · Apr 27, 2020 · 22c53c2 · 22c53c2
1 parent 2749fac
commit 22c53c2
Showing 1 changed file with 5 additions and 14 deletions.
diff --git a/src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/HtmlCSharp/HoverHandler.cs b/src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/HtmlCSharp/HoverHandler.cs
@@ -89,20 +89,11 @@ public async Task<Hover> HandleRequestAsync(TextDocumentPositionParams request,
                 }
             };
 
-            Hover result;
-            try
-            {
-                result = await _requestInvoker.RequestServerAsync<TextDocumentPositionParams, Hover>(
-                    Methods.TextDocumentHoverName,
-                    serverKind,
-                    textDocumentPositionParams,
-                    cancellationToken).ConfigureAwait(false);
-            }
-            catch
-            {
-                // Ensure we fail silently (Temporary till roslyn update is live)
-                return null;
-            }
+            var result = await _requestInvoker.RequestServerAsync<TextDocumentPositionParams, Hover>(
+                Methods.TextDocumentHoverName,
+                serverKind,
+                textDocumentPositionParams,
+                cancellationToken).ConfigureAwait(false);
 
             if (result?.Range == null || result?.Contents == null)
             {