Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop including Microsoft.AspNetCore.Razor.LanguageServer as a MEF component #10099

Closed
Tracked by #9806
DustinCampbell opened this issue Mar 14, 2024 · 2 comments · Fixed by #10102
Closed
Tracked by #9806

Stop including Microsoft.AspNetCore.Razor.LanguageServer as a MEF component #10099

DustinCampbell opened this issue Mar 14, 2024 · 2 comments · Fixed by #10102
Assignees
@DustinCampbell @davidwengier
Milestone
17.10 P3

Comments

@DustinCampbell
Copy link
Member

The RazorExtension VSIX includes Microsoft.AspNetCore.Razor.LanguageServer as a MEF component, which definitely makes it very unclear what the Visual Studio MEF composition contains. To solve this, we should stop registering MS.ANC.Razor.LanguageServer with MEF, and add VS implementations for any needed Exports.
@DustinCampbell DustinCampbell self-assigned this Mar 14, 2024
@DustinCampbell DustinCampbell mentioned this issue Mar 14, 2024
Closed
8 tasks
@davidwengier
Copy link
Member

I'm stealing this from you @DustinCampbell, since I added it, I'll clean it up. Will open the PR if https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9247248&view=results passes

@davidwengier davidwengier self-assigned this Mar 15, 2024
@DustinCampbell
Copy link
Member Author

I'm stealing this from you @DustinCampbell, since I added it, I'll clean it up. Will open the PR if https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9247248&view=results passes

Sweet!

@davidwengier davidwengier mentioned this issue Mar 15, 2024
Merged
@davidwengier davidwengier added this to the 17.10 P3 milestone Mar 15, 2024
davidwengier added a commit that referenced this issue Mar 15, 2024
@davidwengier
Remove and ban MEF in LanguageServer project (#10102)
11edeff 
Fixes #10099

All of the deleted files here were already being removed/moved in
#10097. This was only added to MEF
for cohosting, and its definitely not needed any more. Also added in the
new banned api files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DustinCampbell DustinCampbell

@davidwengier davidwengier

Labels
None yet
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging a pull request may close this issue.

Remove and ban MEF in LanguageServer project dotnet/razor
2 participants
@DustinCampbell @davidwengier