Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Formatting endpoints to cohosting #10743

Closed
phil-allen-msft opened this issue Aug 15, 2024 · 0 comments · Fixed by #10822
Closed

Port Formatting endpoints to cohosting #10743

phil-allen-msft opened this issue Aug 15, 2024 · 0 comments · Fixed by #10822
Assignees
Milestone

Comments

@phil-allen-msft
Copy link
Contributor

No description provided.

@phil-allen-msft phil-allen-msft added this to the Backlog milestone Aug 15, 2024
@davidwengier davidwengier self-assigned this Aug 21, 2024
davidwengier added a commit that referenced this issue Aug 30, 2024
I nerd sniped myself thinking about how to get formatting into
cohosting, given the limitations Alex ran into doing the relayering for
auto insert, and this is the result. I was going to go further and port
the actual formatting endpoint to cohosting, but that would have ran
into the same issue that Alex did with auto insert, so I figured I'd
wait for that to merge, and put this up in the meantime.

This unblocks the formatting, code action and completion end points from
being ported.
Part of #10743
Part of #9519

I **strongly** recommend reviewing commit-at-a-time, as I did this
deliberately in an order, and in order to (hopefully) make reviewing
easier. Though granted, there are a lot of commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants