Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract to code behind loses trivia/whitespace #8750

Closed
davidwengier opened this issue May 20, 2023 · 0 comments · Fixed by #9262
Closed

Extract to code behind loses trivia/whitespace #8750

davidwengier opened this issue May 20, 2023 · 0 comments · Fixed by #9262
Assignees
@davidwengier
Milestone
17.8 Planning

Comments

@davidwengier
Copy link
Contributor

Running extract to code behind loses trivia on members.

Before:
image

After:
image
@ghost ghost added the untriaged label May 20, 2023
@phil-allen-msft phil-allen-msft added this to the 17.7 Planning milestone May 25, 2023
@ghost ghost removed the untriaged label May 25, 2023
@davidwengier davidwengier mentioned this issue Sep 10, 2023
Merged
@davidwengier davidwengier self-assigned this Sep 10, 2023
davidwengier added a commit that referenced this issue Sep 12, 2023
@davidwengier
Keep whitespace in extract to code behind (#9262)
25f8cf1 
Fixes #8750

The main fix here is to not use NormalizeWhitespace, but the formatter
instead, as the former clobbers too much of the users code.
Commit-at-a-time is probably the way to go, to see how the test output
changes (or doesn't 😛)
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidwengier davidwengier

Labels
None yet
Projects
None yet
Milestone
17.8 Planning
Development

Successfully merging a pull request may close this issue.

Keep whitespace in extract to code behind davidwengier/razor
2 participants
@davidwengier @phil-allen-msft