Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up VS Code logging #9142

Closed
davidwengier opened this issue Aug 21, 2023 · 0 comments · Fixed by dotnet/vscode-csharp#6770 or #9745
Closed

Fix up VS Code logging #9142

davidwengier opened this issue Aug 21, 2023 · 0 comments · Fixed by dotnet/vscode-csharp#6770 or #9745
Assignees
@davidwengier
Labels
bug Something isn't working
Milestone
17.9 Planning

Comments

@davidwengier
Copy link
Contributor

In VS Code there are three settings for Razor logging, "Off", "Messages" and "Verbose". Off is the default, but due to a bug in the C# side we actually always log as Verbose regardless of the setting.

We should fix this up to use more standard level names (ie, Debug, Information, Warning, Error) and we should actually honor what the user sets. Also should probably default to Warning or Information, rather than Off. We should probably also change the name of the setting to razor.server.trace from the current razor.trace to better match the C# extension, and the VS Code documentation for LSP servers.
@ghost ghost added the untriaged label Aug 21, 2023
@phil-allen-msft phil-allen-msft added this to the 17.8 Planning milestone Sep 11, 2023
@ghost ghost removed the untriaged label Sep 11, 2023
@phil-allen-msft phil-allen-msft added bug Something isn't working untriaged and removed untriaged labels Sep 11, 2023
This was referenced Dec 21, 2023
Merged
Merged
@davidwengier davidwengier self-assigned this Dec 21, 2023
davidwengier added a commit that referenced this issue Dec 22, 2023
@davidwengier
Make VS Code logging use LogLevel, and filter appropriately (#9745)
8936658 
Fixes #9142

Client side that "consumes" this is
dotnet/vscode-csharp#6770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
bug Something isn't working
Projects
None yet
Milestone
17.9 Planning
2 participants
@davidwengier @phil-allen-msft