Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify handling of the @ character in razor code blocks #10232

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Commits on Apr 6, 2024

  1. Configuration menu
    Copy the full SHA
    ebee3cb View commit details
    Browse the repository at this point in the history
  2. Unify test diagnostic handling. We will now always verify the diagnos…

    …tics reported by the C# compiler. At some point, we should consider doing the same for Razor diagnostics, but that can be done as a future step.
    333fred committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    242e871 View commit details
    Browse the repository at this point in the history
  3. Add new tests and record initial baselines to show how changes will a…

    …ffect parsing recovery.
    333fred committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    6a6cc1f View commit details
    Browse the repository at this point in the history
  4. Consistently handle @ signs in csharp code blocks

    We were not consistently handling recovery after seeing `@` signs in code blocks, which meant that there were all sorts of interesting scenarios where an escaped C# identifier would cause odd error recovery. There are a few edge cases that are now compile errors, but this is a more consistent overall experience. Fixes dotnet#10186 as well.
    333fred committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ab53753 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f66aceb View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. PR Feedback.

    333fred committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    946f600 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    55f7d82 View commit details
    Browse the repository at this point in the history