Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main #10679

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Merge main #10679

merged 2 commits into from
Jul 29, 2024

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jul 29, 2024

Merge main into the feature branch

Those platforms do not have nullable-annotated BCLs, so things like `Debug.Assert` do not work as expected and cause spurious warnings. This is the same approach that Roslyn takes: https://github.com/dotnet/roslyn/blob/main/eng/targets/Imports.targets#L35-L42.
* upstream/main:
  Disable nullable warnings on .NET Standard and Framework (dotnet#10677)
@333fred 333fred enabled auto-merge July 29, 2024 18:56
@333fred 333fred requested a review from a team July 29, 2024 18:56
@333fred 333fred merged commit a35513a into dotnet:feature/roslyn-tokenizer Jul 29, 2024
12 checks passed
@333fred 333fred deleted the merge-main branch July 29, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants