Merge release/dev17.11 to main #10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elease/dev17.8-to-release/dev17.10 * upstream/release/dev17.8: Manually reference Microsoft.IO.Redist 6.0.1 where needed to fix CG alerts. Upgrade testing analyzers to address CG alert.
This is an automatically generated pull request from release/dev17.8 into release/dev17.10. Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯 ## Troubleshooting conflicts ### Identify authors of changes which introduced merge conflicts Scroll to the bottom, then for each file containing conflicts copy its path into the following searches: - https://github.com/dotnet/razor/find/release/dev17.8 - https://github.com/dotnet/razor/find/release/dev17.10 Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts. ### Resolve merge conflicts using your local repo Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub. ``` bash git fetch --all git checkout -t upstream/merges/release/dev17.8-to-release/dev17.10 git reset --hard upstream/release/dev17.10 git merge upstream/release/dev17.8 # Fix merge conflicts git commit git push upstream merges/release/dev17.8-to-release/dev17.10 --force ```
…release/dev17.10-to-release/dev17.11 * upstream/release/dev17.10: Upgrade System.Security.Cryptography.Xml to avoid CG alerts. Update System.Formats.Asn1 to address CG alert. Manually reference Microsoft.IO.Redist 6.0.1 where needed to fix CG alerts. Upgrade testing analyzers to address CG alert.
This is an automatically generated pull request from release/dev17.10 into release/dev17.11. Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯 ## Troubleshooting conflicts ### Identify authors of changes which introduced merge conflicts Scroll to the bottom, then for each file containing conflicts copy its path into the following searches: - https://github.com/dotnet/razor/find/release/dev17.10 - https://github.com/dotnet/razor/find/release/dev17.11 Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts. ### Resolve merge conflicts using your local repo Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub. ``` bash git fetch --all git checkout -t upstream/merges/release/dev17.10-to-release/dev17.11 git reset --hard upstream/release/dev17.11 git merge upstream/release/dev17.10 # Fix merge conflicts git commit git push upstream merges/release/dev17.10-to-release/dev17.11 --force ```
dotnet-bot
added
area-infrastructure
auto-merge
|
⚠ This PR has merge conflicts. @davidwengier |
…release/dev17.11-to-main
davidwengier
approved these changes
Aug 13, 2024
333fred
reviewed
Aug 13, 2024
| @@ -25,8 +25,6 @@ | |||
| <PackageReference Include="Microsoft.CommonLanguageServerProtocol.Framework" PrivateAssets="all" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" /> | |||
| <!-- Manually upgrade to address CG alert. When the VS packages | |||
| pull in the right version, this can be removed. --> | |||
| <PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" /> | |||
There was a problem hiding this comment.
Why not remove this packageref?
| @@ -41,7 +41,6 @@ | |||
| <!-- Manually upgrade to address CG alert. When the VS packages | |||
| pull in the right version, this can be removed. --> | |||
| <PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" /> | |||
There was a problem hiding this comment.
Why not remove this packageref?
333fred
reviewed
Aug 13, 2024
| @@ -15,6 +15,9 @@ | |||
| <PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol.Extensions" /> | |||
| <PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol.Internal" /> | |||
| <PackageReference Include="Microsoft.VisualStudio.LanguageServer.Client.Implementation" /> | |||
| <!-- Manually upgrade to address CG alert. When the VS packages | |||
| pull in the right version, this can be removed. --> | |||
| <PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" /> | |||
| @@ -24,6 +24,9 @@ | |||
|
|
|||
| <PackageReference Include="Microsoft.VisualStudio.LiveShare" /> | |||
| <PackageReference Include="Microsoft.VisualStudio.Shell.15.0" /> | |||
| <!-- Manually upgrade to address CG alert. When the VS packages | |||
| pull in the right version, this can be removed. --> | |||
| <PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" /> | |||
| @@ -41,6 +41,9 @@ | |||
| <ItemGroup> | |||
| <!-- To include the ProvideCodeBase attribute type. --> | |||
| <PackageReference Include="Microsoft.VisualStudio.Shell.15.0" /> | |||
| <!-- Manually upgrade to address CG alert. When the VS packages | |||
| pull in the right version, this can be removed. --> | |||
| <PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" /> | |||
| @@ -211,6 +211,9 @@ | |||
| <PackageReference Include="Microsoft.NET.Sdk.Razor" IncludeAssets="None" PrivateAssets="All" GeneratePathProperty="true" /> | |||
| <PackageReference Include="System.Resources.Extensions" /> | |||
| <PackageReference Include="Microsoft.VisualStudio.Shell.15.0" /> | |||
| <!-- Manually upgrade to address CG alert. When the VS packages | |||
| pull in the right version, this can be removed. --> | |||
| <PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" /> | |||
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from release/dev17.11 into main.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/release/dev17.11-to-main git reset --hard upstream/main git merge upstream/release/dev17.11 # Fix merge conflicts git commit git push upstream merges/release/dev17.11-to-main --force