Code

Cohosting OnAutoInsert endpoint#10776

Code

Merged

alexgav merged 64 commits intomaindotnet/razor:mainfrom dev/alexgav/CohostingOnAutoInsertEndpointdotnet/razor:dev/alexgav/CohostingOnAutoInsertEndpointCopy head branch name to clipboardAug 29, 2024

+1,684-825

Commits

Commits on Aug 29, 2024

• Factoring out AutoInsertService

  alexgav

  committed
  b9abac6

  Copy full SHA for b9abac6

• Switch non-cohost endpoint to use new AutoInsertService

  alexgav

  committed
  330a670

  Copy full SHA for 330a670

• Adding Remote and OOB AutoInsertService classes and OnAutoInsertProviders

  alexgav

  committed
  fe520b8

  Copy full SHA for fe520b8

• Add common code for capabilities

  alexgav

  committed
  c5506e6

  Copy full SHA for c5506e6

• Add cohost OnAutoInsert endpoint

  alexgav

  committed
  3f74c03

  Copy full SHA for 3f74c03

• Parameter rename

  alexgav

  committed
  85cf1f1

  Copy full SHA for 85cf1f1

• Update src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInsert/AutoClosingTagOnAutoInsertProvider.cs

  Show description for be0e85f
  

  alexgav

  and

  davidwengier

  committed
  be0e85f

  Copy full SHA for be0e85f

• Update src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInsert/IAutoInsertService.cs

  Show description for 3ee7479
  

  alexgav

  and

  davidwengier

  committed
  3ee7479

  Copy full SHA for 3ee7479

• Update src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/AutoInsert/InsertTextEdit.cs

  Show description for 5cb62c3
  

  alexgav

  and

  davidwengier

  committed
  5cb62c3

  Copy full SHA for 5cb62c3

• Fixup after rebase

  alexgav

  committed
  38c9436

  Copy full SHA for 38c9436

• More post-build cleanup

  alexgav

  committed
  4a6d7f6

  Copy full SHA for 4a6d7f6

• Move common HTML and C# auto-insert trigger chars per CR suggestion

  alexgav

  committed
  09452b5

  Copy full SHA for 09452b5

• More cleanup after rebase

  alexgav

  committed
  447dd54

  Copy full SHA for 447dd54

• Add IOnAutoInsertTiggerCharacterProvider per CR suggestion

  alexgav

  committed
  70430a4

  Copy full SHA for 70430a4

• Removing trigger characters property from RemoteAutoInsertService per CR suggestion

  alexgav

  committed
  02db4e4

  Copy full SHA for 02db4e4

• Switch to using RemoteResponse

  alexgav

  committed
  b3ec796

  Copy full SHA for b3ec796

• Fixup bad resolve after rebase, and extra whitespace in RazorLangaugeServer

  alexgav

  committed
  2813a97

  Copy full SHA for 2813a97

• Complete capabilities check in CohostingOnAutoInsertEndpoing registration

  alexgav

  committed
  f19fd7f

  Copy full SHA for f19fd7f

• Change input position type to serializable :LinePosition

  alexgav

  committed
  1dbc2c2

  Copy full SHA for 1dbc2c2

• Fixing RemoteInsertTextEdit to use properly annotated (for serialization) types only

  alexgav

  committed
  c324f34

  Copy full SHA for c324f34

• Support for delegating auto-insert to C#

  alexgav

  committed
  10c8c15

  Copy full SHA for 10c8c15

• Fixup after rebase

  alexgav

  committed
  c5dd51a

  Copy full SHA for c5dd51a

• Fixup AutoClosingTagOnAutoInsertProviderTest tests

  alexgav

  committed
  2fd5c8a

  Copy full SHA for 2fd5c8a

• Fixinfg up CloseTextTagOnAutoInsertProviderTest tests

  alexgav

  committed
  75f73a0

  Copy full SHA for 75f73a0

• Fixing up OnAutoInsertEndpointTest (which also tests the new AutoInsertService)

  alexgav

  committed
  2c40c10

  Copy full SHA for 2c40c10

• Fixing duplicate OnAutoInsert handler registration (bad merge after rebate)

  alexgav

  committed
  770808f

  Copy full SHA for 770808f

• Fixes to MEF composition issue and capabilities check

  Show description for bf7c45e
  alexgav

  committed
  bf7c45e

  Copy full SHA for bf7c45e

• Fixing incorrect export type

  alexgav

  committed
  ced0724

  Copy full SHA for ced0724

• Minor cleanup per CR suggestions

  alexgav

  committed
  52c7acb

  Copy full SHA for 52c7acb

• Switching parameters to RazorCodeDocument and removing async in a lot of places per CR suggestion

  alexgav

  committed
  6808099

  Copy full SHA for 6808099

• Fixing build - removing unneeded using

  alexgav

  committed
  d72bbb0

  Copy full SHA for d72bbb0

• Fix RemoteAutoInsertService logic to follow existing code (always prefer our own AutoInsertService first)

  alexgav

  committed
  4170302

  Copy full SHA for 4170302

• Check allowed trigger characters before delegating to other languages/servers

  alexgav

  committed
  5c36ad1

  Copy full SHA for 5c36ad1

• Plumbing through actual option values we need and using them

  alexgav

  committed
  e695e4a

  Copy full SHA for e695e4a

• Fixup After Rebase

  alexgav

  committed
  ca86e8f

  Copy full SHA for ca86e8f

• Consuming RazorFormattingService in remote OnAutoInsert service

  alexgav

  committed
  0970a46

  Copy full SHA for 0970a46

• Fixing exception in RemoteProjectSnapshot.Configuration

  Show description for 8db5313
  alexgav

  committed
  8db5313

  Copy full SHA for 8db5313

• Switch to PreferHtmlInAttributeValuesDocumentPositionInfoStrategy as the original code does

  Show description for 2357c4a
  alexgav

  committed
  2357c4a

  Copy full SHA for 2357c4a

• Cleanup usings

  alexgav

  committed
  536fe77

  Copy full SHA for 536fe77

• More usings cleanup

  alexgav

  committed
  5e47c94

  Copy full SHA for 5e47c94

• PR feedback - minor cleanup and removal of InsertTextEdit type in favor of VSInternalDocumentOnAutoInsertResponseItem

  alexgav

  committed
  e2d4b65

  Copy full SHA for e2d4b65

• PR feedback - removing MEF usage from RemoteAdhocWorkspaceFactory, minor cleanup

  alexgav

  committed
  614af2e

  Copy full SHA for 614af2e

• PR feedback

  alexgav

  committed
  0f1d30d

  Copy full SHA for 0f1d30d

• Type and method renames, minor cleanup per PR feedback

  alexgav

  committed
  01d3d80

  Copy full SHA for 01d3d80

• Renaming interface methods, removing unnecessary usage of FrozenSet

  alexgav

  committed
  7d61fbf

  Copy full SHA for 7d61fbf

• Use ImmutableArray to store providers

  alexgav

  committed
  a7df9ef

  Copy full SHA for a7df9ef

• Switching to bool and out on IAutoInsertService and implementation

  alexgav

  committed
  34beda3

  Copy full SHA for 34beda3

• Cleaned up document position info calculation per PR feedback

  alexgav

  committed
  a4beaef

  Copy full SHA for a4beaef

• Minor cleanup in RemoteAutoInsertService

  alexgav

  committed
  4613364

  Copy full SHA for 4613364

• Cleanup trigger character calculation in CohostOnAutoInsertEndpoint

  alexgav

  committed
  bf389fb

  Copy full SHA for bf389fb

• Formatting changes, VsLspFactory usage

  alexgav

  committed
  c9e5130

  Copy full SHA for c9e5130

• Revert to MEF DI in RemoteAdhocWorkspaceFactory/RemoteRazorFormattingService

  alexgav

  committed
  9d339ef

  Copy full SHA for 9d339ef

• Removing Rolsyn to VS LSP extension methods

  alexgav

  committed
  a629cf3

  Copy full SHA for a629cf3

• Switch to raw strings in tests and minor whitespace cleanup

  alexgav

  committed
  46c9356

  Copy full SHA for 46c9356

• Rename per PR feedback suggestion to better indicate the purpose

  alexgav

  committed
  0eab010

  Copy full SHA for 0eab010

• Cleanup formatting code document acquisition per PR feedback

  Show description for 7bb3d32
  alexgav

  committed
  7bb3d32

  Copy full SHA for 7bb3d32

• Removing redundant assert as compiler is already doing the check

  alexgav

  committed
  e53bf51

  Copy full SHA for e53bf51

• Unnecessary assignment cleanup

  alexgav

  committed
  348f76f

  Copy full SHA for 348f76f

• Misc PR feedback cleanup

  alexgav

  committed
  c984b46

  Copy full SHA for c984b46

• Made GetGeneratedOutputAsync an extension method per PR feedback

  alexgav

  committed
  3f9fe84

  Copy full SHA for 3f9fe84

• Remaining MEF parameter attrivute formatting changes

  alexgav

  committed
  69105c1

  Copy full SHA for 69105c1

• Last of the PR feedback.

  alexgav

  committed
  137d9ad

  Copy full SHA for 137d9ad

• Fixing most unit test failures.

  Show description for 7715a4c
  alexgav

  committed
  7715a4c

  Copy full SHA for 7715a4c

• Fixing last 4 unit test failures

  Show description for ffaa2ef
  alexgav

  committed
  ffaa2ef

  Copy full SHA for ffaa2ef