Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on type formatting #10949

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix on type formatting #10949

merged 4 commits into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. Fix the bug

    @davidwengier
    davidwengier committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    eb5f92a View commit details
    Browse the repository at this point in the history

  2. Fix incorrect method name

    @davidwengier
    davidwengier committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    bbc53f0 View commit details
    Browse the repository at this point in the history

  3. Add a test to prove it wasn't a formatting bug

    @davidwengier
    davidwengier committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e4acdcb View commit details
    Browse the repository at this point in the history

  4. Add a test to validate the fix, and fix existing tests, and one more … 

    …bug 🤦‍♂️
    @davidwengier
    davidwengier committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4ae58de View commit details
    Browse the repository at this point in the history