Some random clean up and improvements #11095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change move OSSkipConditionFactAttribute.cs in every test project and removes file links it in every test project.
This change replaces OSSkipConditionFactAttribute a more generally useful ConditionalFactAttribute (and ConditionalTheoryAttribute. This makes it easier to see what conditions a test *should* execute under rather that which conditions it shouldn't.
davidwengier
approved these changes
Oct 26, 2024
ryzngard
approved these changes
Oct 26, 2024
|
@dotnet/razor-compiler: I'm guessing this PR isn't too controversial, but it does make some small changes to compiler code. So, it'll need a couple of sign offs. |
chsienki
approved these changes
Oct 28, 2024
jaredpar
approved these changes
Oct 28, 2024
src/Shared/Microsoft.AspNetCore.Razor.Test.Common/ConditionalFactAttribute.cs
Show resolved
Hide resolved
phil-allen-msft
added a commit
that referenced
this pull request
Nov 6, 2024
phil-allen-msft
added a commit
that referenced
this pull request
Nov 6, 2024
jjonescz
added a commit
that referenced
this pull request
Nov 7, 2024
jjonescz
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just some tweaks I've had on my machine awhile.
PlatformInformationclass to remove severalRuntimeInformation.IsOSPlatform(...). These checks are fairly efficient, but each requires in a string comparison and it's easy enough to just do those once and remember the result.OSSkipConditionFactAttributewithConditionalFactAttribute. This makes it easier to see what conditions a test will run under. For example, it's much easier to see that a test will run on Windows if it's marked with[ConditionalFact(Is.Windows)]rather than[OSSkipConditionFact(["Linux", "OSX"])]