-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Roslyn package references to latest available and do minor fixup #11113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very glad that you separated this out from your other PR! This is definitely a separate concern from the completion work.
I added a comment that describes the changes needed to correctly pass the VSInternalClientCapabilities.SupportsVisualStudioExtensions
from the client. Also, it looks like this change causes test failures. Those will need to be fixed up before I can sign off.
src/Compiler/Microsoft.AspNetCore.Razor.Language/test/MetadataCollectionTests.cs
Outdated
Show resolved
Hide resolved
...Razor/src/Microsoft.CodeAnalysis.Remote.Razor/DocumentSymbols/RemoteDocumentSymbolService.cs
Outdated
Show resolved
Hide resolved
Roslyn was requesting new IRazorMappingService and our TestRazorDocumentServiceProvider was throwing. Returning null for now per suggestion from Andrew.
All appear to have been due to the new IRazorMappingService that's in Roslyn but not yet in Razor. Returning null rather that throwing for that service request in test code per Andrew. |
...soft.AspNetCore.Razor.Test.Common.Tooling/LanguageServer/TestRazorDocumentServiceProvider.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this if a TODO comment is added in the code to link the issue to the hard-coded bit.
@dotnet/razor-compiler ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compiler LGTM
Summary of the changes