Push hover logic to Workspaces layer #11119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IHoverService.GetRazorHoverInfoAsync(...) takes a DocumentPositionInfo and an LSP Position, but it only actually needs one of them.
Rather than passing around ClientCapabilities all the time, use a HoverDisplayOptions record with the relevant information.
Change HoverService to pass around LinePositionSpan throughtout and only create an LSP Range when needed in the end.
Rather than accessing the _projectManager instance field in HoverService, just pass an ISolutionQueryOperations instance throughout.
Moving the existing hover tests requires a few test infrastructure changes.
Now that the implementation of GetHoverAsync has moved to Workspaces, HoverService really doesn't need to carry on.
davidwengier
approved these changes
Oct 30, 2024
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Hover/HoverEndpoint.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Hover/HoverDisplayOptions.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Hover/HoverService.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Oct 30, 2024
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/AbstractRazorDelegatingEndpoint.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves all of the logic that computes a
VSInternalHoverto the Workspaces layer. The file diff shouldn't be too bad, but a lot of code is moved without much additional clean up. So, it might be easier to go commit-by-commit.