Cohost code actions

[davidwengier]

Fixes #10742
Needs dotnet/roslyn#75711 before it will build
Also will need to merge in main once #11141 is merged

[davidwengier]

Merged main and bumped to a real Roslyn build, so this is ready for review

[davidwengier]

@dotnet/razor-compiler Your Microsoft.AspNetCore.Razor.Language.Legacy.CSharpStatementTest.SwitchStatement_ListPattern test failed, I'm guessing due to some change in Roslyn this is bringing in inadvertently? Is this expected? Should I just regen the baselines?

[jjonescz]

@dotnet/razor-compiler Your Microsoft.AspNetCore.Razor.Language.Legacy.CSharpStatementTest.SwitchStatement_ListPattern test failed, I'm guessing due to some change in Roslyn this is bringing in inadvertently? Is this expected? Should I just regen the baselines?

Please try regenerating the baseline so we can see the diff, it's not very clear from the test results

[davidwengier]

Please try regenerating the baseline so we can see the diff, it's not very clear from the test results

Spread changed to two dots? Seems odd to me, but not necessarily anything to worry about I suppose: https://github.com/dotnet/razor/pull/11147/files#diff-77d4727ed03808a308baf4eb6f7861529d0a9d23e86b2b51dda9eb9d719b62bd

[jjonescz]

Looks like result of dotnet/roslyn#75549.

[DustinCampbell]

Looks very good!

[DustinCampbell]

This file looks super cool. 😄

[davidwengier]

ehh, it's okay. I don't like that we have to just manually make sure this matches everything in the LSP server DI container.

[DustinCampbell]

Consider not creating a new async state machine.

Suggested change

	public async Task<string?> GetFormattedNewFileContentsAsync(IProjectSnapshot projectSnapshot, Uri csharpFileUri, string newFileContent, CancellationToken cancellationToken)
	{
	Debug.Assert(projectSnapshot is RemoteProjectSnapshot);
	var project = ((RemoteProjectSnapshot)projectSnapshot).Project;
	var document = project.AddDocument(RazorUri.GetDocumentFilePathFromUri(csharpFileUri), newFileContent);
	return await ExternalHandlers.CodeActions.GetFormattedNewFileContentAsync(document, cancellationToken).ConfigureAwait(false);
	}
	public Task<string?> GetFormattedNewFileContentsAsync(IProjectSnapshot projectSnapshot, Uri csharpFileUri, string newFileContent, CancellationToken cancellationToken)
	{
	Debug.Assert(projectSnapshot is RemoteProjectSnapshot);
	var project = ((RemoteProjectSnapshot)projectSnapshot).Project;
	var document = project.AddDocument(RazorUri.GetDocumentFilePathFromUri(csharpFileUri), newFileContent);
	return ExternalHandlers.CodeActions.GetFormattedNewFileContentAsync(document, cancellationToken);
	}

[davidwengier]

Okay, but I need to employ a ! because the Roslyn method returns Task<string>, so its not pretty. Unless I'm forgetting some other way to avoid the nullability compiler warning?

[DustinCampbell]

Ahhh... I see. Yeah, that's unfortunate. However, if the Roslyn method returns a Task<string>, why does this return a Task<string?>? It doesn't look to me like this method can return null. Or, is the Roslyn method not annotated correctly? Or, can this also return a Task<string>?

[davidwengier]

It's the non-cohost impl. It makes an LSP call, so can always be null.

[davidwengier]

Had a shower thought, I can make this non-nullable by moving the bit that handles null into the non-cohost impl. Thank you for the brain spark :D

[davidwengier]

@dotnet/razor-compiler for second sign off on test baseline changes

[jjonescz]

@dotnet/razor-compiler for second sign off on test baseline changes

Test changes should be good to go with just one sign off.