More cohost code actions tests! #11179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ugh, how is it possible to work in VS for literal hours, running tests, hitting the build button, looking in the error list the whole time, and then there be compile errors 🤦♂️ |
davidwengier
commented
Nov 8, 2024
...t/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostCodeActionsEndpointTest.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostCodeActionsEndpointTest.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostCodeActionsEndpointTest.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostCodeActionsEndpointTest.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostCodeActionsEndpointTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't originally test some code actions because they used the file system, so I intended this PR to fix that by abstracting the file system away. It is that, but I also found some more tests that we lacked coverage for in cohosting, and since I find the cohosting tests to be just so wonderful (not biased at all, obviously) I thought I'd be a bit extra.
I deliberately didn't try to fix any of the code actions, but I think they could probably all do with some nicer whitespace handling. Managed to avoid the self-nerd-snipe this time though.