Move named pipe support #11206
Merged
Move named pipe support #11206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since INamesPipeProjectInfoDriver is a contract between MS.ANC.Razor.LanguageServer and RZLS, it doesn't need to live in Razor.Workspaces. Instead, it should live in the language server's Hosting namespace.
I noticed a logging message that seemed to indicate an error rather than an informational message.
Since this is only used within the language server for named pipe support, it can live in the language server rather than Razor.Workspaces.
This change moves the necessary extension methods to the MS.ANC.Razor.LanguageServer.Hosting namespace to avoid needing to expose a larger namespace outside of the language server. RestrictedInternalsVisibleTo is a tool for controlling the implicit surface area of the language server, and we should add to that surface area judiciously.
This switches an incorrect usage of NotImplementedException to InvalidOperationException
davidwengier
approved these changes
Nov 13, 2024
ryzngard
approved these changes
Nov 13, 2024
|
Thanks! |
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the named pipe support is intended to only be used by RZLS, this change moves the support types into
MS.ANC.Razor.LanguageServerand organizes them in aMS.ANC.Razor.LanguageServer.Hosting.NamedPipesnamespace. In addition, I've moved a couple ofIServiceCollectionextension methods into theMS.ANC.Razor.LanguageServer.Hostingnamespace to avoid opening up internals visible to access to the entireMS.ANC.Razor.LanguageServer.Extensionnamespace, even if it's just to RZLS. The goal of havingRestrictedInternalsVisibleTofor theMS.ANC.Razor.LanguageServer.Hostingnamespace is to control the exposed surface area of the language server. If something is needed by VS or RZLS, strongly consider whether it should just be added to theHostingnamespace to avoid unintentionally dependencies that might need to be detangled later.Note: Once this is merged, I'll submit a PR to update the code pointer comment at https://github.com/dotnet/vscode-csharp/blob/eb38986a52a8be7221d0e466f7a25c98dcbd7825/src/razor/src/razorLanguageServerClient.ts#L228.