Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extract component whitespace handling #11262

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Fix extract component whitespace handling #11262

merged 5 commits into from
Nov 27, 2024

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Nov 27, 2024 •
edited
Loading

fixes #11261

@ryzngard ryzngard requested a review from a team as a code owner November 27, 2024 20:56
davidwengier
davidwengier approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting code FTW

@ryzngard ryzngard merged commit e4d1b9e into dotnet:main Nov 27, 2024
12 checks passed
@ryzngard ryzngard deleted the extract_component_start_fix branch November 27, 2024 23:00
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 27, 2024
@dotnet-bot dotnet-bot mentioned this pull request Nov 29, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

Extract to component over selects the code to extract
2 participants
@ryzngard @davidwengier