Use correct serializer options when serializing and deserializing #11268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deserializing in cohosting. Deserializing to VS LSP types should use VS LSP converters, and deserializing to Roslyn LSP types should use Roslyn LSP converters. Otherwise things mostly work, but you can end up with base versions of the types instead of VSInternal subtypes.
davidwengier
approved these changes
Dec 3, 2024
ryzngard
approved these changes
Dec 3, 2024
This was referenced Dec 12, 2024
This was referenced Apr 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't always using correct serializer options when serializing and deserializing in cohosting. E.g. deserializing to VS LSP types should use VS LSP converters, and deserializing to Roslyn LSP types should use Roslyn LSP converters. Otherwise, things mostly work, but you can end up with base versions of the types instead of VSInternal subtypes.
I found this issue when I realized that VSInternalClientCapabilities wasn't getting deserialized quite right - top level was VSInternal version, but all fields (and their fields) were not properly deserialized to their VSInternal versions.
Also adding a couple of common helper methods to make serialization/deserializion code easier to keep consistent.
### Summary of the changes
-Common helpers for serialization and deserialization
-Make sure correct converters are used for both VL LSP and Roslyn LSP types