-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused field in LspServices #11358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
One minor change needed before we can merge though
davidwengier
approved these changes
Jan 7, 2025
Thanks Matt! |
Created #11359 for follow up, so we don't break things in future |
davidwengier
added a commit
that referenced
this pull request
Jan 8, 2025
Related to #11358 Discovered another unused field to be removed.
davidwengier
added a commit
that referenced
this pull request
Jan 8, 2025
Fixes #11359 IDE0052 wasn't being enforced in CI which means we broke the VMR build (see #11358 and #11361). This change makes sure this rule is turned on and enforced in command line builds, and fixes a couple of violations in the compiler. Should prevent future breakages too. Not sure why out existing .editorconfig for this diagnostic didn't work, but I suspect its because the compiler has its own .editorconfig marked as root.
This was referenced Jan 14, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the latest daily build of the .NET 10 SDK to build this repo, it results in the following errors:
This is fixed by removing these unused fields.