-
Notifications
You must be signed in to change notification settings - Fork 219
Upgrade to net9 #11535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to net9 #11535
Changes from all commits
1d97873
c7b613d
257460c
031c05a
cdd7641
030aa9e
585e62b
ea1cec2
96f3b7e
072381f
a850008
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,10 @@ | |
| <!-- By default, nothing builds from source build. Individual projects can opt in instead --> | ||
| <ExcludeFromSourceOnlyBuild>true</ExcludeFromSourceOnlyBuild> | ||
|
|
||
| <DefaultNetFxTargetFramework>net472</DefaultNetFxTargetFramework> | ||
| <NetFxVS>net472</NetFxVS> | ||
| <NetVS>net8.0</NetVS> | ||
| <NetVSCode>net9.0</NetVSCode> | ||
| <NetVSAndVSCode>$(NetVS);$(NetVSCode)</NetVSAndVSCode> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- | ||
|
|
@@ -61,8 +64,9 @@ | |
| --> | ||
| <When Condition="'$(DotNetBuildSourceOnly)' == 'true' AND '$(DotNetBuildOrchestrator)' != 'true'"> | ||
| <PropertyGroup> | ||
| <DefaultNetCoreTargetFramework>$(NetCurrent)</DefaultNetCoreTargetFramework> | ||
| <DefaultNetCoreTargetFrameworks>$(DefaultNetCoreTargetFramework);$(NetPrevious)</DefaultNetCoreTargetFrameworks> | ||
| <NetVS>$(NetCurrent)</NetVS> | ||
| <NetVSCode>$(NetCurrent)</NetVSCode> | ||
| <NetVSAndVSCode>$(NetVS);$(NetVSCode);$(NetPrevious)</NetVSAndVSCode> | ||
| </PropertyGroup> | ||
| </When> | ||
|
|
||
|
|
@@ -71,20 +75,11 @@ | |
| --> | ||
| <When Condition="'$(DotNetBuildSourceOnly)' == 'true' AND '$(DotNetBuildOrchestrator)' == 'true'"> | ||
| <PropertyGroup> | ||
| <DefaultNetCoreTargetFramework>$(NetCurrent)</DefaultNetCoreTargetFramework> | ||
| <DefaultNetCoreTargetFrameworks>$(DefaultNetCoreTargetFramework)</DefaultNetCoreTargetFrameworks> | ||
| <NetVS>$(NetCurrent)</NetVS> | ||
| <NetVSCode>$(NetCurrent)</NetVSCode> | ||
| <NetVSAndVSCode>$(NetVS);$(NetVSCode)</NetVSAndVSCode> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks wrong. When building the product from source, only the latest TFM should get built. See roslyn's defines as an example: https://github.com/dotnet/roslyn/blob/c02ed62551e0880585f14b511cc1b9ba4c48bcf2/eng/targets/TargetFrameworks.props#L53-L61 Is there any reason why those older TFMs got added? cc @dotnet/source-build @jaredpar
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So only
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes |
||
| </PropertyGroup> | ||
| </When> | ||
|
|
||
| <!-- | ||
| 3. Everything else including normal CI, developer machines and official builds. | ||
| --> | ||
| <Otherwise> | ||
| <PropertyGroup> | ||
| <DefaultNetCoreTargetFramework>net8.0</DefaultNetCoreTargetFramework> | ||
| <DefaultNetCoreTargetFrameworks>$(DefaultNetCoreTargetFramework)</DefaultNetCoreTargetFrameworks> | ||
| </PropertyGroup> | ||
| </Otherwise> | ||
| </Choose> | ||
|
|
||
| <ItemGroup> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.