Fuse/typeparamintellisense #11795
Merged
Fuse/typeparamintellisense #11795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Just use roslyn directly as we no longer have the split between language / csharp
jjonescz
approved these changes
Apr 30, 2025
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/TypeNameHelper.cs
Outdated
Show resolved
Hide resolved
...er/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentGenericTypePass.cs
Outdated
Show resolved
Hide resolved
...Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentCodeGenerationTestBase.cs
Show resolved
Hide resolved
Member
Author
|
@333fred for a second review, thanks! |
Member
There was a problem hiding this comment.
Thank you! I had a branch on my machine where I'd removed this as well. 😄
DustinCampbell
approved these changes
May 7, 2025
333fred
reviewed
May 7, 2025
...er/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentGenericTypePass.cs
Show resolved
Hide resolved
333fred
approved these changes
May 8, 2025
DustinCampbell
pushed a commit
that referenced
this pull request
May 9, 2025
Track tokens in the TypeNameRewriter so we can emit source information for where the supplied type param comes from. Fixes #11552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on fixing #11552